diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-10-17 17:57:51 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-10-17 17:57:51 +0000 |
| commit | 5ae6c564d16ce8b625df3d1950abc822f9ecc987 (patch) | |
| tree | 96bb64df3166e46db397e405789588bf8dc53842 /fpdfsdk/fpdf_transformpage.cpp | |
| parent | 785a26dc649af80c593f899a606dff4dae7c48fd (diff) | |
| download | pdfium-5ae6c564d16ce8b625df3d1950abc822f9ecc987.tar.xz | |
Add CPDF_{Array,Dictionary}Locker to catch illegal iteration patterns.
Move begin/end methods onto locker object which tracks whether
iterators are in existence.
Change-Id: Ia869f313fce48d10a0d0180d0cc083eed6ea1584
Reviewed-on: https://pdfium-review.googlesource.com/c/44070
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fpdfsdk/fpdf_transformpage.cpp')
| -rw-r--r-- | fpdfsdk/fpdf_transformpage.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/fpdfsdk/fpdf_transformpage.cpp b/fpdfsdk/fpdf_transformpage.cpp index 8e8c9d5b70..debf38b47e 100644 --- a/fpdfsdk/fpdf_transformpage.cpp +++ b/fpdfsdk/fpdf_transformpage.cpp @@ -219,11 +219,12 @@ FPDFPage_TransFormWithClip(FPDF_PAGE page, if (!pRes) return true; - CPDF_Dictionary* pPattenDict = pRes->GetDictFor("Pattern"); - if (!pPattenDict) + CPDF_Dictionary* pPatternDict = pRes->GetDictFor("Pattern"); + if (!pPatternDict) return true; - for (const auto& it : *pPattenDict) { + CPDF_DictionaryLocker locker(pPatternDict); + for (const auto& it : locker) { CPDF_Object* pObj = it.second.get(); if (pObj->IsReference()) pObj = pObj->GetDirect(); |