summaryrefslogtreecommitdiff
path: root/fpdfsdk/fpdfannot_embeddertest.cpp
diff options
context:
space:
mode:
authorHenrique Nakashima <hnakashima@chromium.org>2018-03-26 20:37:40 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-03-26 20:37:40 +0000
commitac3e57eee888904d39a07b58ca7d57f8f8b0e51a (patch)
treec688e06925b2d6cb6ea5198cc67715a34c79d60d /fpdfsdk/fpdfannot_embeddertest.cpp
parent2c47fb2c9b3db7be3480cbc044fa90fda988b97f (diff)
downloadpdfium-ac3e57eee888904d39a07b58ca7d57f8f8b0e51a.tar.xz
Revert "Add FPDFAnnot_CountAttachmentPoints"
This reverts commit ca28cb636331de447125de476decbec333fe613b. Reason for revert: broke Windows embeddertests https://build.chromium.org/p/client.pdfium/builders/windows/builds/4622 I got it when landing my CL, which is unrelated. Since this CL passed the bot, I'm guessing it's a flaky test? Original change's description: > Add FPDFAnnot_CountAttachmentPoints > > This CL adds a function to the API that returns the number of quadpoint > sets. > > Change-Id: I999bc567a4c98f6c32e87810e7ecfbb634c7b677 > Reviewed-on: https://pdfium-review.googlesource.com/29130 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> TBR=thestig@chromium.org,dsinclair@chromium.org,ralf.sippl@gmail.com Change-Id: Id96b5d4e18be2184c9d24f77bda7499aad0ed211 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://pdfium-review.googlesource.com/29190 Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Diffstat (limited to 'fpdfsdk/fpdfannot_embeddertest.cpp')
-rw-r--r--fpdfsdk/fpdfannot_embeddertest.cpp21
1 files changed, 1 insertions, 20 deletions
diff --git a/fpdfsdk/fpdfannot_embeddertest.cpp b/fpdfsdk/fpdfannot_embeddertest.cpp
index 552398c41f..b96460a395 100644
--- a/fpdfsdk/fpdfannot_embeddertest.cpp
+++ b/fpdfsdk/fpdfannot_embeddertest.cpp
@@ -47,7 +47,7 @@ TEST_F(FPDFAnnotEmbeddertest, RenderAnnotWithOnlyRolloverAP) {
TEST_F(FPDFAnnotEmbeddertest, RenderMultilineMarkupAnnotWithoutAP) {
const char md5_hash[] = "76512832d88017668d9acc7aacd13dae";
- // Open a file with multiline markup annotations.
+ // Open a file with two multiline markup annotations.
ASSERT_TRUE(OpenDocument("annotation_markup_multiline_no_ap.pdf"));
FPDF_PAGE page = LoadPage(0);
ASSERT_TRUE(page);
@@ -471,25 +471,6 @@ TEST_F(FPDFAnnotEmbeddertest, ModifyRectQuadpointsWithAP) {
UnloadPage(page);
}
-TEST_F(FPDFAnnotEmbeddertest, CountAttachmentPoints) {
- // Open a file with multiline markup annotations.
- ASSERT_TRUE(OpenDocument("annotation_markup_multiline_no_ap.pdf"));
- FPDF_PAGE page = LoadPage(0);
- ASSERT_TRUE(page);
- {
- std::unique_ptr<void, FPDFAnnotationDeleter> annot(
- FPDFPage_GetAnnot(page, 0));
- ASSERT_TRUE(annot);
-
- // This is a three line annotation.
- EXPECT_EQ(3u, FPDFAnnot_CountAttachmentPoints(annot.get()));
- }
- UnloadPage(page);
-
- // null annotation should return 0
- EXPECT_EQ(0u, FPDFAnnot_CountAttachmentPoints(nullptr));
-}
-
TEST_F(FPDFAnnotEmbeddertest, RemoveAnnotation) {
// Open a file with 3 annotations on its first page.
ASSERT_TRUE(OpenDocument("annotation_ink_multiple.pdf"));