diff options
| author | Tom Sepez <tsepez@chromium.org> | 2017-05-16 15:33:20 -0700 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-05-16 23:26:47 +0000 |
| commit | fe91c6c8211cec39f871d9202556e1957bf81983 (patch) | |
| tree | b7e763f7affe4c71de67393fbd320c1fed477e0f /fpdfsdk/fpdfdoc.cpp | |
| parent | 365333552cf67b7c97c4093177e7ed7b43f540ab (diff) | |
| download | pdfium-fe91c6c8211cec39f871d9202556e1957bf81983.tar.xz | |
Be skeptical of bare |new|s.
In particular, prefer an explicit .release() call when handing
ownership of an object to a caller across a C-API.
Change-Id: Ic3784e9d0b2d378a08d388989eaea7c9166bacd1
Reviewed-on: https://pdfium-review.googlesource.com/5470
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'fpdfsdk/fpdfdoc.cpp')
| -rw-r--r-- | fpdfsdk/fpdfdoc.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fpdfsdk/fpdfdoc.cpp b/fpdfsdk/fpdfdoc.cpp index 0c8e26ceac..70a27a5011 100644 --- a/fpdfsdk/fpdfdoc.cpp +++ b/fpdfsdk/fpdfdoc.cpp @@ -230,8 +230,7 @@ DLLEXPORT FPDF_BOOL STDCALL FPDFDest_GetLocationInPage(FPDF_DEST pDict, if (!pDict) return false; - std::unique_ptr<CPDF_Dest> dest( - new CPDF_Dest(static_cast<CPDF_Object*>(pDict))); + auto dest = pdfium::MakeUnique<CPDF_Dest>(static_cast<CPDF_Object*>(pDict)); // FPDF_BOOL is an int, GetXYZ expects bools. bool bHasX; |