diff options
| author | Tom Sepez <tsepez@chromium.org> | 2016-03-15 12:43:09 -0700 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2016-03-15 12:43:09 -0700 |
| commit | 744da70149c450d2f387a1fa325a3074ac2edb0c (patch) | |
| tree | 91889184989b49e0899a110aab9808efaea4ca14 /fpdfsdk/fpdfeditpage.cpp | |
| parent | 3a8051c8cb55e3c108c1f860dc743c42827ae4fa (diff) | |
| download | pdfium-744da70149c450d2f387a1fa325a3074ac2edb0c.tar.xz | |
FPDF_PageDelete must delete XFA pages as well.
Currently, it is only deleting the CPDF_ resources, which
are wrapped by XFA objects in an XFA build. Hence, if a page
is deleted and then re-inserted, we get the old contents. In
print preview, chromium first inserts blank pages and then
replaces them later on, causing the associated bug.
BUG=594111
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1804163002 .
Diffstat (limited to 'fpdfsdk/fpdfeditpage.cpp')
| -rw-r--r-- | fpdfsdk/fpdfeditpage.cpp | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/fpdfsdk/fpdfeditpage.cpp b/fpdfsdk/fpdfeditpage.cpp index e10f3825af..493329c360 100644 --- a/fpdfsdk/fpdfeditpage.cpp +++ b/fpdfsdk/fpdfeditpage.cpp @@ -57,11 +57,8 @@ DLLEXPORT FPDF_DOCUMENT STDCALL FPDF_CreateNewDocument() { } DLLEXPORT void STDCALL FPDFPage_Delete(FPDF_DOCUMENT document, int page_index) { - CPDF_Document* pDoc = CPDFDocumentFromFPDFDocument(document); - if (!pDoc || page_index < 0 || page_index >= pDoc->GetPageCount()) - return; - - pDoc->DeletePage(page_index); + if (UnderlyingDocumentType* pDoc = UnderlyingFromFPDFDocument(document)) + pDoc->DeletePage(page_index); } DLLEXPORT FPDF_PAGE STDCALL FPDFPage_New(FPDF_DOCUMENT document, |