summaryrefslogtreecommitdiff
path: root/fpdfsdk/fpdfformfill_embeddertest.cpp
diff options
context:
space:
mode:
authorHenrique Nakashima <hnakashima@chromium.org>2018-03-19 21:21:46 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-03-19 21:21:46 +0000
commit20830920ca028f551dcdb54e5170317d61254419 (patch)
tree61900617f099bf079ee7a569a9e4938e0b16efe1 /fpdfsdk/fpdfformfill_embeddertest.cpp
parentef44194f4f4c71b6e1bbaecb5ffff503d780766c (diff)
downloadpdfium-20830920ca028f551dcdb54e5170317d61254419.tar.xz
Add more options to combobox_form.pdf resource.
This causes a scrollbar to appear. We need a test case that contains an AcroForm combobox with a popup that is large enough to create a scrollbar. Bug: chromium:823378, chromium:820278 Change-Id: I6e93bda5b938f9f7c08ceeef7989794ea7764532 Reviewed-on: https://pdfium-review.googlesource.com/28750 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'fpdfsdk/fpdfformfill_embeddertest.cpp')
-rw-r--r--fpdfsdk/fpdfformfill_embeddertest.cpp15
1 files changed, 9 insertions, 6 deletions
diff --git a/fpdfsdk/fpdfformfill_embeddertest.cpp b/fpdfsdk/fpdfformfill_embeddertest.cpp
index 8b81467822..709bc39bfa 100644
--- a/fpdfsdk/fpdfformfill_embeddertest.cpp
+++ b/fpdfsdk/fpdfformfill_embeddertest.cpp
@@ -224,10 +224,14 @@ class FPDFFormFillComboBoxFormEmbeddertest
}
void SelectEditableFormOption(int item_index) {
+ ASSERT(item_index >= 0);
+ ASSERT(item_index < 3);
SelectOption(item_index, EditableFormDropDown());
}
void SelectNonEditableFormOption(int item_index) {
+ ASSERT(item_index >= 0);
+ ASSERT(item_index < 26);
SelectOption(item_index, NonEditableFormDropDown());
}
@@ -281,10 +285,6 @@ class FPDFFormFillComboBoxFormEmbeddertest
// Selects one of the pre-selected values from a combobox with three options.
// Options are specified by |item_index|, which is 0-based.
void SelectOption(int item_index, const CFX_PointF& point) {
- // Only relevant for comboboxes with three choices and the same dimensions
- // as those in combobox_form.pdf.
- ASSERT(item_index >= 0);
- ASSERT(item_index < 3);
// Navigate to button for drop down and click mouse to reveal options.
ClickOnFormFieldAtPoint(point);
@@ -294,6 +294,9 @@ class FPDFFormFillComboBoxFormEmbeddertest
CFX_PointF option_point = point;
option_point.y -= kChoiceHeight * (item_index + 1);
+ // Move left to avoid scrollbar.
+ option_point.x -= 20;
+
// Navigate to option and click mouse to select it.
ClickOnFormFieldAtPoint(option_point);
}
@@ -301,8 +304,8 @@ class FPDFFormFillComboBoxFormEmbeddertest
static constexpr float kFormBeginX = 102.0;
static constexpr float kFormEndX = 183.0;
static constexpr float kFormDropDownX = 192.0;
- static constexpr float kEditableFormY = 60.0;
- static constexpr float kNonEditableFormY = 110.0;
+ static constexpr float kEditableFormY = 360.0;
+ static constexpr float kNonEditableFormY = 410.0;
};
TEST_F(FPDFFormFillEmbeddertest, FirstTest) {