diff options
| author | dsinclair <dsinclair@chromium.org> | 2016-10-13 12:07:42 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-10-13 12:07:42 -0700 |
| commit | f3736bca5f874b0889c5906ffbd74a405089f671 (patch) | |
| tree | ef3a3731f4dfd6b5e3e7f957b1d8e1b61a1a1804 /fpdfsdk/fpdfview.cpp | |
| parent | 271d9c0a85b50208baa8789ba6b245956317f719 (diff) | |
| download | pdfium-f3736bca5f874b0889c5906ffbd74a405089f671.tar.xz | |
Reland: Make the CPDFXFA_App non-global
This reverts commit b685e6471075bebd26711bc183de3128f54932e3.
This CL changes CPDFXFA_App from a global object to a child of the CPDFXFA_Document objects.
BUG=pdfium:623
Review-Url: https://codereview.chromium.org/2418653003
Diffstat (limited to 'fpdfsdk/fpdfview.cpp')
| -rw-r--r-- | fpdfsdk/fpdfview.cpp | 21 |
1 files changed, 9 insertions, 12 deletions
diff --git a/fpdfsdk/fpdfview.cpp b/fpdfsdk/fpdfview.cpp index 3ab81fe112..cb0cf5917c 100644 --- a/fpdfsdk/fpdfview.cpp +++ b/fpdfsdk/fpdfview.cpp @@ -42,6 +42,7 @@ #include "fpdfsdk/fpdfxfa/cpdfxfa_page.h" #include "fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.h" #include "public/fpdf_formfill.h" +#include "xfa/fxbarcode/BC_Library.h" #endif // PDF_ENABLE_XFA #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_ @@ -70,8 +71,8 @@ CPDF_Document* CPDFDocumentFromFPDFDocument(FPDF_DOCUMENT doc) { FPDF_DOCUMENT FPDFDocumentFromCPDFDocument(CPDF_Document* doc) { #ifdef PDF_ENABLE_XFA - return doc ? FPDFDocumentFromUnderlying(new CPDFXFA_Document( - pdfium::WrapUnique(doc), CPDFXFA_App::GetInstance())) + return doc ? FPDFDocumentFromUnderlying( + new CPDFXFA_Document(pdfium::WrapUnique(doc))) : nullptr; #else // PDF_ENABLE_XFA return FPDFDocumentFromUnderlying(doc); @@ -285,19 +286,19 @@ FPDF_InitLibraryWithConfig(const FPDF_LIBRARY_CONFIG* cfg) { pModuleMgr->LoadEmbeddedKorea1CMaps(); #ifdef PDF_ENABLE_XFA - CPDFXFA_App::GetInstance()->Initialize( - (cfg && cfg->version >= 2) ? static_cast<v8::Isolate*>(cfg->m_pIsolate) - : nullptr); + FXJSE_Initialize(); + BC_Library_Init(); #endif // PDF_ENABLE_XFA - if (cfg && cfg->version >= 2) IJS_Runtime::Initialize(cfg->m_v8EmbedderSlot, cfg->m_pIsolate); } DLLEXPORT void STDCALL FPDF_DestroyLibrary() { #ifdef PDF_ENABLE_XFA - CPDFXFA_App::ReleaseInstance(); + BC_Library_Destory(); + FXJSE_Finalize(); #endif // PDF_ENABLE_XFA + CPDF_ModuleMgr::Destroy(); CFX_GEModule::Destroy(); @@ -377,11 +378,7 @@ DLLEXPORT FPDF_DOCUMENT STDCALL FPDF_LoadDocument(FPDF_STRING file_path, ProcessParseError(error); return nullptr; } -#ifdef PDF_ENABLE_XFA - return new CPDFXFA_Document(std::move(pDocument), CPDFXFA_App::GetInstance()); -#else // PDF_ENABLE_XFA - return pDocument.release(); -#endif // PDF_ENABLE_XFA + return FPDFDocumentFromCPDFDocument(pDocument.release()); } #ifdef PDF_ENABLE_XFA |