Cleanup CPDFXFA_App methods

This CL removes methods which are never called, or are only called once
and return a static value. Those values are inlined at the calling site.

Review-Url: https://codereview.chromium.org/2418633002

1 files changed, 2 insertions, 21 deletions

diff --git a/fpdfsdk/fpdfxfa/cpdfxfa_app.cpp b/fpdfsdk/fpdfxfa/cpdfxfa_app.cpp
index 626a07eb29..61694d0a28 100644
--- a/fpdfsdk/fpdfxfa/cpdfxfa_app.cpp
+++ b/fpdfsdk/fpdfxfa/cpdfxfa_app.cpp
@@ -35,9 +35,7 @@ void CPDFXFA_App::ReleaseInstance() {
 }
 
 CPDFXFA_App::CPDFXFA_App()
-    : m_bJavaScriptInitialized(FALSE),
-      m_pIsolate(nullptr),
-      m_csAppType(JS_STR_VIEWERTYPE_STANDARD) {
+    : m_bJavaScriptInitialized(FALSE), m_pIsolate(nullptr) {
   m_pFormFillEnvList.RemoveAll();
 }
 
@@ -86,20 +84,12 @@ FX_BOOL CPDFXFA_App::RemoveFormFillEnv(
   return FALSE;
 }
 
-void CPDFXFA_App::GetAppType(CFX_WideString& wsAppType) {
-  wsAppType = m_csAppType;
-}
-
 void CPDFXFA_App::GetAppName(CFX_WideString& wsName) {
   CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pFormFillEnvList.GetAt(0);
   if (pFormFillEnv)
     wsName = pFormFillEnv->FFI_GetAppName();
 }
 
-void CPDFXFA_App::SetAppType(const CFX_WideStringC& wsAppType) {
-  m_csAppType = wsAppType;
-}
-
 void CPDFXFA_App::GetLanguage(CFX_WideString& wsLanguage) {
   CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pFormFillEnvList.GetAt(0);
   if (pFormFillEnv)
@@ -113,19 +103,10 @@ void CPDFXFA_App::GetPlatform(CFX_WideString& wsPlatform) {
   }
 }
 
-void CPDFXFA_App::GetVariation(CFX_WideString& wsVariation) {
-  wsVariation = JS_STR_VIEWERVARIATION;
-}
-
-void CPDFXFA_App::GetVersion(CFX_WideString& wsVersion) {
-  wsVersion = JS_STR_VIEWERVERSION_XFA;
-}
-
 void CPDFXFA_App::Beep(uint32_t dwType) {
   CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pFormFillEnvList.GetAt(0);
-  if (pFormFillEnv) {
+  if (pFormFillEnv)
     pFormFillEnv->JS_appBeep(dwType);
-  }
 }
 
 int32_t CPDFXFA_App::MsgBox(const CFX_WideString& wsMessage,