diff options
| author | thestig <thestig@chromium.org> | 2016-04-14 18:29:56 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-04-14 18:29:56 -0700 |
| commit | b1a59597db4b8ce3ffc34dbfda2fb1ecb80c2397 (patch) | |
| tree | 4bef693fc2b5722a86d75ee6110da8c9d5530f6d /fpdfsdk/fpdfxfa | |
| parent | b1c80fb8b843a2a345b2cd6005e591dc731355f4 (diff) | |
| download | pdfium-b1a59597db4b8ce3ffc34dbfda2fb1ecb80c2397.tar.xz | |
Simplify XFA event handling.
- Avoid casting to void*
- Don't bother firing events that no one listens for
Review URL: https://codereview.chromium.org/1890563003
Diffstat (limited to 'fpdfsdk/fpdfxfa')
| -rw-r--r-- | fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp | 4 | ||||
| -rw-r--r-- | fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h | 4 |
2 files changed, 2 insertions, 6 deletions
diff --git a/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp b/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp index 53068d345d..d55183751e 100644 --- a/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp +++ b/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp @@ -521,9 +521,7 @@ void CPDFXFA_Document::PageViewEvent(CXFA_FFPageView* pPageView, void CPDFXFA_Document::WidgetEvent(CXFA_FFWidget* hWidget, CXFA_WidgetAcc* pWidgetData, - uint32_t dwEvent, - void* pParam, - void* pAdditional) { + uint32_t dwEvent) { if (m_iDocType != DOCTYPE_DYNAMIC_XFA || !hWidget) return; diff --git a/fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h b/fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h index 2d4311f55f..5ffeb21022 100644 --- a/fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h +++ b/fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h @@ -73,9 +73,7 @@ class CPDFXFA_Document : public IXFA_DocProvider { // dwEvent refer to XFA_WIDGETEVENT_XXX virtual void WidgetEvent(CXFA_FFWidget* hWidget, CXFA_WidgetAcc* pWidgetData, - uint32_t dwEvent, - void* pParam = NULL, - void* pAdditional = NULL); + uint32_t dwEvent); // return true if render it. virtual FX_BOOL RenderCustomWidget(CXFA_FFWidget* hWidget, |