diff options
| author | tsepez <tsepez@chromium.org> | 2016-12-07 09:21:17 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-12-07 09:21:18 -0800 |
| commit | 833619b4441915c7c55085d44b3221eaef0d9800 (patch) | |
| tree | 68bf76e83078223ba03f490c2c13f484e40154d4 /fpdfsdk/fsdk_define.h | |
| parent | 8f875507a986d10335e40a5f7c1679aff9770d0a (diff) | |
| download | pdfium-833619b4441915c7c55085d44b3221eaef0d9800.tar.xz | |
Refcount all the IFX_ stream classes all the time.
We can remove a lot of "bOwnsStream" logic in the process.
Always pass these by const reference, in case the called method
wants to hang on to the stream (one exception is where we stick
a raw pointer into a void* slot in a context from another layer).
Review-Url: https://codereview.chromium.org/2451493002
Diffstat (limited to 'fpdfsdk/fsdk_define.h')
| -rw-r--r-- | fpdfsdk/fsdk_define.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/fpdfsdk/fsdk_define.h b/fpdfsdk/fsdk_define.h index a3f5a30836..9a115966db 100644 --- a/fpdfsdk/fsdk_define.h +++ b/fpdfsdk/fsdk_define.h @@ -27,12 +27,14 @@ class IFSDK_PAUSE_Adapter; // Layering prevents fxcrt from knowing about FPDF_FILEACCESS, so this can't // be a static method of IFX_SeekableReadStream. -IFX_SeekableReadStream* MakeSeekableReadStream(FPDF_FILEACCESS* pFileAccess); +CFX_RetainPtr<IFX_SeekableReadStream> MakeSeekableReadStream( + FPDF_FILEACCESS* pFileAccess); #ifdef PDF_ENABLE_XFA // Layering prevents fxcrt from knowing about FPDF_FILEHANDLER, so this can't // be a static method of IFX_SeekableStream. -IFX_SeekableStream* MakeSeekableStream(FPDF_FILEHANDLER* pFileHandler); +CFX_RetainPtr<IFX_SeekableStream> MakeSeekableStream( + FPDF_FILEHANDLER* pFileHandler); #endif // PDF_ENABLE_XFA // Object types for public FPDF_ types; these correspond to next layer down |