diff options
| author | tsepez <tsepez@chromium.org> | 2016-05-16 13:21:03 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-05-16 13:21:03 -0700 |
| commit | cc4d6d85b58a7a1d9d7b798c63d3343f3dac06a9 (patch) | |
| tree | fda580a573f97d15c9484c57ebf8fae66342ab83 /fpdfsdk/fsdk_mgr.cpp | |
| parent | e699c66433049396e438d983a1837b9d4a4cf766 (diff) | |
| download | pdfium-cc4d6d85b58a7a1d9d7b798c63d3343f3dac06a9.tar.xz | |
Remove { delete this; } anti-pattern from IXFA_WidgetIterator
Review-Url: https://codereview.chromium.org/1976123003
Diffstat (limited to 'fpdfsdk/fsdk_mgr.cpp')
| -rw-r--r-- | fpdfsdk/fsdk_mgr.cpp | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/fpdfsdk/fsdk_mgr.cpp b/fpdfsdk/fsdk_mgr.cpp index 4ab4850c4d..2d641783f9 100644 --- a/fpdfsdk/fsdk_mgr.cpp +++ b/fpdfsdk/fsdk_mgr.cpp @@ -905,10 +905,11 @@ void CPDFSDK_PageView::LoadFXAnnots() { m_page->AddRef(); if (m_pSDKDoc->GetXFADocument()->GetDocType() == DOCTYPE_DYNAMIC_XFA) { CXFA_FFPageView* pageView = m_page->GetXFAPageView(); - IXFA_WidgetIterator* pWidgetHander = pageView->CreateWidgetIterator( - XFA_TRAVERSEWAY_Form, XFA_WIDGETFILTER_Visible | - XFA_WIDGETFILTER_Viewable | - XFA_WIDGETFILTER_AllType); + std::unique_ptr<IXFA_WidgetIterator> pWidgetHander( + pageView->CreateWidgetIterator(XFA_TRAVERSEWAY_Form, + XFA_WIDGETFILTER_Visible | + XFA_WIDGETFILTER_Viewable | + XFA_WIDGETFILTER_AllType)); if (!pWidgetHander) { m_page->Release(); SetLock(FALSE); @@ -919,11 +920,9 @@ void CPDFSDK_PageView::LoadFXAnnots() { CPDFSDK_Annot* pAnnot = pAnnotHandlerMgr->NewAnnot(pXFAAnnot, this); if (!pAnnot) continue; - m_fxAnnotArray.push_back(pAnnot); pAnnotHandlerMgr->Annot_OnLoad(pAnnot); } - pWidgetHander->Release(); } else { CPDF_Page* pPage = m_page->GetPDFPage(); ASSERT(pPage); |