Make code compile with clang_use_chrome_plugin (part IV)

This change mainly contains files in fpdfsdk/ directory.
This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups plus removing an unused file and splitting
cxfa_eventparam out from fxfa.h

BUG=pdfium:469

Review-Url: https://codereview.chromium.org/2062313002

1 files changed, 6 insertions, 7 deletions

diff --git a/fpdfsdk/fxedit/include/fxet_list.h b/fpdfsdk/fxedit/include/fxet_list.h
index ab4605169b..a763db52da 100644
--- a/fpdfsdk/fxedit/include/fxet_list.h
+++ b/fpdfsdk/fxedit/include/fxet_list.h
@@ -142,11 +142,10 @@ class CFX_ListItem final {
 
 class CFX_ListContainer {
  public:
-  CFX_ListContainer()
-      : m_rcPlate(0.0f, 0.0f, 0.0f, 0.0f),
-        m_rcContent(0.0f, 0.0f, 0.0f, 0.0f) {}
-  virtual ~CFX_ListContainer() {}
-  virtual void SetPlateRect(const CFX_FloatRect& rect) { m_rcPlate = rect; }
+  CFX_ListContainer();
+  virtual ~CFX_ListContainer();
+  virtual void SetPlateRect(const CFX_FloatRect& rect);
+
   CFX_FloatRect GetPlateRect() const { return m_rcPlate; }
   void SetContentRect(const CLST_Rect& rect) { m_rcContent = rect; }
   CLST_Rect GetContentRect() const { return m_rcContent; }
@@ -297,8 +296,8 @@ class CFX_ListCtrl : public CFX_List {
   void SetScrollPos(const CFX_FloatPoint& point) override;
   void ScrollToListItem(int32_t nItemIndex) override;
   CFX_FloatRect GetItemRect(int32_t nIndex) const override;
-  int32_t GetCaret() const override { return m_nCaretIndex; }
-  int32_t GetSelect() const override { return m_nSelItem; }
+  int32_t GetCaret() const override;
+  int32_t GetSelect() const override;
   int32_t GetTopItem() const override;
   CFX_FloatRect GetContentRect() const override;
   int32_t GetItemIndex(const CFX_FloatPoint& point) const override;