diff options
| author | jaepark <jaepark@google.com> | 2016-08-31 06:49:27 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-08-31 06:49:27 -0700 |
| commit | 956553e715787cfc4dd8423d5e9a04a0131878c3 (patch) | |
| tree | 08622d504322d5dae37b5bb5025a90c81ebdee6b /fpdfsdk/include/cba_annotiterator.h | |
| parent | 87dffc0315477150c9c1964913b65bc97bdf654f (diff) | |
| download | pdfium-956553e715787cfc4dd8423d5e9a04a0131878c3.tar.xz | |
Use enum class for subtypes of CPDF_Annot.
Comparing CFX_ByteString for annotation subtypes is inefficient and
error-prone. This CL uses enum class to compare annotation subtypes.
Also, remove unused IPDFSDK_AnnotHandler::GetType() and
FSDK_XFAWIDGET_TYPENAME.
Review-Url: https://codereview.chromium.org/2295953002
Diffstat (limited to 'fpdfsdk/include/cba_annotiterator.h')
| -rw-r--r-- | fpdfsdk/include/cba_annotiterator.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fpdfsdk/include/cba_annotiterator.h b/fpdfsdk/include/cba_annotiterator.h index 0cf6e6a0ef..aa0ad2d72b 100644 --- a/fpdfsdk/include/cba_annotiterator.h +++ b/fpdfsdk/include/cba_annotiterator.h @@ -9,6 +9,7 @@ #include <vector> +#include "core/fpdfdoc/include/cpdf_annot.h" #include "core/fxcrt/include/fx_coordinates.h" #include "core/fxcrt/include/fx_string.h" @@ -20,7 +21,7 @@ class CBA_AnnotIterator { enum TabOrder { STRUCTURE = 0, ROW, COLUMN }; CBA_AnnotIterator(CPDFSDK_PageView* pPageView, - const CFX_ByteString& sAnnotSubtype); + CPDF_Annot::Subtype nAnnotSubtype); ~CBA_AnnotIterator(); CPDFSDK_Annot* GetFirstAnnot(); @@ -40,7 +41,7 @@ class CBA_AnnotIterator { TabOrder m_eTabOrder; CPDFSDK_PageView* m_pPageView; - CFX_ByteString m_sAnnotSubtype; + CPDF_Annot::Subtype m_nAnnotSubtype; std::vector<CPDFSDK_Annot*> m_Annots; }; |