diff options
| author | tsepez <tsepez@chromium.org> | 2016-05-25 14:58:09 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-05-25 14:58:09 -0700 |
| commit | 1e2c557e0fa0e47c8bafdb31c833ea4f90f5fedd (patch) | |
| tree | 86c90cdb10f3c478570934816a56070ed6d51260 /fpdfsdk/include/fsdk_mgr.h | |
| parent | edfd3c3d6a56bee2456e96df4b945c095ea3a290 (diff) | |
| download | pdfium-1e2c557e0fa0e47c8bafdb31c833ea4f90f5fedd.tar.xz | |
Remove CFX_PrivateData from CPDF_Page
CFX_PrivateData served two purposes here:
The first was to hold an opaque pointer to the corresponding
page structure in the next higher layer, of which it knows
no details. Introduce an empty CPDF_Page::View class to
represent this higher class, so as to get type safety while
preserving layering.
The second was to hold an opaque render context, which it
also happened to own. Make this a CFX_Deletable to help
with management.
Also remove an unused inheritance from CFX_PrivateData
in CPDF_Annot.
Review-Url: https://codereview.chromium.org/2008553008
Diffstat (limited to 'fpdfsdk/include/fsdk_mgr.h')
| -rw-r--r-- | fpdfsdk/include/fsdk_mgr.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fpdfsdk/include/fsdk_mgr.h b/fpdfsdk/include/fsdk_mgr.h index ca46a069f1..a47f230c92 100644 --- a/fpdfsdk/include/fsdk_mgr.h +++ b/fpdfsdk/include/fsdk_mgr.h @@ -11,6 +11,7 @@ #include <memory> #include <vector> +#include "core/fpdfapi/fpdf_page/include/cpdf_page.h" #include "core/fpdfapi/fpdf_parser/include/cpdf_document.h" #include "fpdfsdk/cfx_systemhandler.h" #include "fpdfsdk/include/fsdk_actionhandler.h" @@ -530,7 +531,7 @@ class CPDFSDK_Document { FX_BOOL m_bBeingDestroyed; }; -class CPDFSDK_PageView final { +class CPDFSDK_PageView final : public CPDF_Page::View { public: CPDFSDK_PageView(CPDFSDK_Document* pSDKDoc, UnderlyingPageType* page); ~CPDFSDK_PageView(); |