diff options
| author | Jochen Eisinger <jochen@chromium.org> | 2015-05-19 00:38:00 +0200 |
|---|---|---|
| committer | Jochen Eisinger <jochen@chromium.org> | 2015-05-19 00:38:00 +0200 |
| commit | dfa2c9939a85ad1c01ef858b21942ab3773dcf27 (patch) | |
| tree | 064ae26fd633fe7ffcc6c72ce59bd2cfdd429246 /fpdfsdk/include/javascript/JS_Object.h | |
| parent | 34d839653f3c7a821dadb8e3219f9a8da83d83e6 (diff) | |
| download | pdfium-dfa2c9939a85ad1c01ef858b21942ab3773dcf27.tar.xz | |
Merge V8 API updates to xfa branch
Set pointers in internal fields directly instead of wrapping them
Review URL: https://codereview.chromium.org/1139853003
Use phantom handles instead of weak handles
Review URL: https://codereview.chromium.org/1129253004
Replace deprecated with non-deprecated V8 APIs
Review URL: https://codereview.chromium.org/1126203010
Add myself to OWNERS file
Review URL: https://codereview.chromium.org/1133333005
Replace v8::Handle with v8::Local and v8::Persistent with v8::Global
Review URL: https://codereview.chromium.org/1138823004
TBR=tsepez@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1140033004
Diffstat (limited to 'fpdfsdk/include/javascript/JS_Object.h')
| -rw-r--r-- | fpdfsdk/include/javascript/JS_Object.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fpdfsdk/include/javascript/JS_Object.h b/fpdfsdk/include/javascript/JS_Object.h index 02d2f57663..a9ad01835c 100644 --- a/fpdfsdk/include/javascript/JS_Object.h +++ b/fpdfsdk/include/javascript/JS_Object.h @@ -46,6 +46,7 @@ public: virtual ~CJS_Object(void); void MakeWeak(); + void Dispose(); virtual FX_BOOL IsType(FX_LPCSTR sClassName){return TRUE;}; virtual CFX_ByteString GetClassName(){return "";}; @@ -66,7 +67,7 @@ public: v8::Isolate* GetIsolate() {return m_pIsolate;} protected: CJS_EmbedObj * m_pEmbedObj; - v8::Persistent<v8::Object> m_pObject; + v8::Global<v8::Object> m_pObject; v8::Isolate* m_pIsolate; }; |