diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-03-02 14:20:10 -0800 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-03-02 14:20:10 -0800 |
| commit | e1671bd3158f5d78f66647ec5489e9538bd4bc36 (patch) | |
| tree | 8103762d77f6ab733cc759b8f8653c0d9fb5d5ea /fpdfsdk/include/javascript/JS_Value.h | |
| parent | b720d0a14601f1496ef15297bc46d401f5a2a890 (diff) | |
| download | pdfium-e1671bd3158f5d78f66647ec5489e9538bd4bc36.tar.xz | |
Kill off JS_ErrorString type.
This provides no benefit, and reduces transparency.
Along the way:
Kill off some unused/commented-out code.
Return void where a bool return doesn't make sense.
Remove a pointless template type.
Remove now unused constants and types.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/971033002
Diffstat (limited to 'fpdfsdk/include/javascript/JS_Value.h')
| -rw-r--r-- | fpdfsdk/include/javascript/JS_Value.h | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/fpdfsdk/include/javascript/JS_Value.h b/fpdfsdk/include/javascript/JS_Value.h index e9faf32370..4962ddcf3d 100644 --- a/fpdfsdk/include/javascript/JS_Value.h +++ b/fpdfsdk/include/javascript/JS_Value.h @@ -73,13 +73,16 @@ protected: v8::Isolate* m_isolate; }; -template<class TYPE> class CJS_ParametersTmpl : public CFX_ArrayTemplate<TYPE> +class CJS_Parameters : public CFX_ArrayTemplate<CJS_Value> { public: - void push_back(TYPE newElement){CFX_ArrayTemplate<TYPE>::Add(newElement);} - int size() const{return CFX_ArrayTemplate<TYPE>::GetSize();} + void push_back(const CJS_Value& newElement) { + CFX_ArrayTemplate<CJS_Value>::Add(newElement); + } + int size() const { + return CFX_ArrayTemplate<CJS_Value>::GetSize(); + } }; -typedef CJS_ParametersTmpl<CJS_Value> CJS_Parameters; class CJS_PropValue: public CJS_Value { |