diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-09-10 11:56:37 -0700 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-09-10 11:56:37 -0700 |
| commit | 6df59849472958e7de96da6d9fc7b223b7c1f1c3 (patch) | |
| tree | 90b4908f6de484252f9757010b7002c4f0365a58 /fpdfsdk/include/javascript/global.h | |
| parent | 0d0935d3d6603dd7d851b1d5828635230f4c43ca (diff) | |
| download | pdfium-6df59849472958e7de96da6d9fc7b223b7c1f1c3.tar.xz | |
Remove some abstractions in fxjs_v8.h.
It's too hard to keep mapping between v8 and fx abstractions; the lack
of transparency prevents those skilled in v8 only from working on this
code.
Apparently, the original intention was to confine v8 types to
fpdfsdk/{include,src}/jsapi, but fpdfsdk/{include,src}/javascript
is already well-polluted with v8 types.
Also remove no-op JS_SetThisObj().
Also remove unused ParserParams() [noticed because it was incorrectly
passing handles as pointers].
Also remove cast operator from CJS_Runtime and call GetIsolate()
explicitly.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1332973002 .
Diffstat (limited to 'fpdfsdk/include/javascript/global.h')
| -rw-r--r-- | fpdfsdk/include/javascript/global.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fpdfsdk/include/javascript/global.h b/fpdfsdk/include/javascript/global.h index 7f78bb6bcb..10300a25ab 100644 --- a/fpdfsdk/include/javascript/global.h +++ b/fpdfsdk/include/javascript/global.h @@ -63,7 +63,7 @@ class JSGlobalAlternate : public CJS_EmbedObj { double dData, bool bData, const CFX_ByteString& sData, - JSObject pData, + v8::Local<v8::Object> pData, bool bDefaultPersistent); void ObjectToArray(v8::Local<v8::Object> pObj, @@ -79,7 +79,7 @@ class JSGlobalAlternate : public CJS_EmbedObj { class CJS_Global : public CJS_Object { public: - explicit CJS_Global(JSFXObject pObject) : CJS_Object(pObject) {} + explicit CJS_Global(v8::Local<v8::Object> pObject) : CJS_Object(pObject) {} ~CJS_Global() override {} // CJS_Object |