diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-10-25 13:30:31 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-10-25 18:40:45 +0000 |
| commit | 8f524d6ff9c5c5e07388438e58aca7dc39f43a1f (patch) | |
| tree | ec73d24ebdfb84e0c9a254a35912edc5ab54dae7 /fpdfsdk/javascript/Annot.h | |
| parent | 2474a3b2d9fe987dac58813771f1fa66427e124f (diff) | |
| download | pdfium-8f524d6ff9c5c5e07388438e58aca7dc39f43a1f.tar.xz | |
Refactor JS method parameters and return values.
This CL removes the out parameters from the JS methods and changes the
return from a |bool| to a |CJS_Return| value. The return value holds the
returned v8 object, error string and a status code.
Change-Id: I82488ff0d916475d7e3c8e51ed868639806181c9
Reviewed-on: https://pdfium-review.googlesource.com/16751
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fpdfsdk/javascript/Annot.h')
| -rw-r--r-- | fpdfsdk/javascript/Annot.h | 22 |
1 files changed, 8 insertions, 14 deletions
diff --git a/fpdfsdk/javascript/Annot.h b/fpdfsdk/javascript/Annot.h index 94b67622e5..b7c951b310 100644 --- a/fpdfsdk/javascript/Annot.h +++ b/fpdfsdk/javascript/Annot.h @@ -15,20 +15,14 @@ class Annot : public CJS_EmbedObj { explicit Annot(CJS_Object* pJSObject); ~Annot() override; - bool get_hidden(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError); - bool set_hidden(CJS_Runtime* pRuntime, - v8::Local<v8::Value> vp, - WideString* sError); - - bool get_name(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError); - bool set_name(CJS_Runtime* pRuntime, - v8::Local<v8::Value> vp, - WideString* sError); - - bool get_type(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError); - bool set_type(CJS_Runtime* pRuntime, - v8::Local<v8::Value> vp, - WideString* sError); + CJS_Return get_hidden(CJS_Runtime* pRuntime); + CJS_Return set_hidden(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp); + + CJS_Return get_name(CJS_Runtime* pRuntime); + CJS_Return set_name(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp); + + CJS_Return get_type(CJS_Runtime* pRuntime); + CJS_Return set_type(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp); void SetSDKAnnot(CPDFSDK_BAAnnot* annot); |