summaryrefslogtreecommitdiff
path: root/fpdfsdk/javascript/Document.cpp
diff options
context:
space:
mode:
authorDan Sinclair <dsinclair@chromium.org>2017-10-26 15:04:17 -0400
committerChromium commit bot <commit-bot@chromium.org>2017-10-26 19:29:57 +0000
commitd808dfd5ad8c4eae1f2ea58b9b54a7d4e45a649e (patch)
tree26b829d19be342d45fa47accd4a599fb2d5aa711 /fpdfsdk/javascript/Document.cpp
parent977c2a048e02dd3a9563be0c2c6ee62435e134c1 (diff)
downloadpdfium-d808dfd5ad8c4eae1f2ea58b9b54a7d4e45a649e.tar.xz
Cleanup JS define methods
This CL moves DefineProps, DefineMethods and DefineConsts to the CJS_Object and removes from the subclasses. The JSConstructor and JSDestructor are moved to be templated static methods in JS_Defines. Change-Id: Ibe5ee063a32ae2332b8affc843d97ee6da21f4ee Reviewed-on: https://pdfium-review.googlesource.com/16930 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fpdfsdk/javascript/Document.cpp')
-rw-r--r--fpdfsdk/javascript/Document.cpp54
1 files changed, 8 insertions, 46 deletions
diff --git a/fpdfsdk/javascript/Document.cpp b/fpdfsdk/javascript/Document.cpp
index a5724e8f76..8175b0d246 100644
--- a/fpdfsdk/javascript/Document.cpp
+++ b/fpdfsdk/javascript/Document.cpp
@@ -41,23 +41,12 @@
const char* CJS_PrintParamsObj::g_pClassName = "PrintParamsObj";
int CJS_PrintParamsObj::g_nObjDefnID = -1;
-void CJS_PrintParamsObj::JSConstructor(CFXJS_Engine* pEngine,
- v8::Local<v8::Object> obj) {
- CJS_Object* pObj = new CJS_PrintParamsObj(obj);
- pObj->SetEmbedObject(new PrintParamsObj(pObj));
- pEngine->SetObjectPrivate(obj, pObj);
- pObj->InitInstance(static_cast<CJS_Runtime*>(pEngine));
-}
-
-void CJS_PrintParamsObj::JSDestructor(CFXJS_Engine* pEngine,
- v8::Local<v8::Object> obj) {
- delete static_cast<CJS_PrintParamsObj*>(pEngine->GetObjectPrivate(obj));
-}
-
void CJS_PrintParamsObj::DefineJSObjects(CFXJS_Engine* pEngine,
FXJSOBJTYPE eObjType) {
- g_nObjDefnID = pEngine->DefineObj(CJS_PrintParamsObj::g_pClassName, eObjType,
- JSConstructor, JSDestructor);
+ g_nObjDefnID =
+ pEngine->DefineObj(CJS_PrintParamsObj::g_pClassName, eObjType,
+ JSConstructor<CJS_PrintParamsObj, PrintParamsObj>,
+ JSDestructor<CJS_PrintParamsObj>);
}
PrintParamsObj::PrintParamsObj(CJS_Object* pJSObject)
@@ -160,40 +149,13 @@ JSMethodSpec CJS_Document::MethodSpecs[] = {
const char* CJS_Document::g_pClassName = "Document";
int CJS_Document::g_nObjDefnID = -1;
-void CJS_Document::JSConstructor(CFXJS_Engine* pEngine,
- v8::Local<v8::Object> obj) {
- CJS_Object* pObj = new CJS_Document(obj);
- pObj->SetEmbedObject(new Document(pObj));
- pEngine->SetObjectPrivate(obj, pObj);
- pObj->InitInstance(static_cast<CJS_Runtime*>(pEngine));
-}
-
-void CJS_Document::JSDestructor(CFXJS_Engine* pEngine,
- v8::Local<v8::Object> obj) {
- delete static_cast<CJS_Document*>(pEngine->GetObjectPrivate(obj));
-}
-
-void CJS_Document::DefineProps(CFXJS_Engine* pEngine) {
- for (size_t i = 0; i < FX_ArraySize(PropertySpecs) - 1; ++i) {
- pEngine->DefineObjProperty(g_nObjDefnID, PropertySpecs[i].pName,
- PropertySpecs[i].pPropGet,
- PropertySpecs[i].pPropPut);
- }
-}
-
-void CJS_Document::DefineMethods(CFXJS_Engine* pEngine) {
- for (size_t i = 0; i < FX_ArraySize(MethodSpecs) - 1; ++i) {
- pEngine->DefineObjMethod(g_nObjDefnID, MethodSpecs[i].pName,
- MethodSpecs[i].pMethodCall);
- }
-}
-
void CJS_Document::DefineJSObjects(CFXJS_Engine* pEngine,
FXJSOBJTYPE eObjType) {
g_nObjDefnID = pEngine->DefineObj(CJS_Document::g_pClassName, eObjType,
- JSConstructor, JSDestructor);
- DefineProps(pEngine);
- DefineMethods(pEngine);
+ JSConstructor<CJS_Document, Document>,
+ JSDestructor<CJS_Document>);
+ DefineProps(pEngine, g_nObjDefnID, PropertySpecs);
+ DefineMethods(pEngine, g_nObjDefnID, MethodSpecs);
}
void CJS_Document::InitInstance(IJS_Runtime* pIRuntime) {