diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-10-26 16:48:30 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-10-26 21:02:17 +0000 |
| commit | ef299534cce8cc42f1bd13665a75947c88195ce0 (patch) | |
| tree | 92e97b4f19dc7d8bdae7c0f43b549ad9d49bcdc4 /fpdfsdk/javascript/Document.h | |
| parent | 15776cf22182e74d8546849780ec0cf61b96ca95 (diff) | |
| download | pdfium-ef299534cce8cc42f1bd13665a75947c88195ce0.tar.xz | |
Cleanup statics in JS classes
This CL removes the static object IDs from each of the CJS_Object
subclasses and moves them to anonymous namespaces. The Spec arrays are
moved to private members of the object classes.
Change-Id: I5dcdb87ef57e4b374b5431580fb55cb75023f8fb
Reviewed-on: https://pdfium-review.googlesource.com/16950
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fpdfsdk/javascript/Document.h')
| -rw-r--r-- | fpdfsdk/javascript/Document.h | 22 |
1 files changed, 13 insertions, 9 deletions
diff --git a/fpdfsdk/javascript/Document.h b/fpdfsdk/javascript/Document.h index 0073042f25..6f9acd2cfb 100644 --- a/fpdfsdk/javascript/Document.h +++ b/fpdfsdk/javascript/Document.h @@ -34,13 +34,15 @@ class PrintParamsObj : public CJS_EmbedObj { class CJS_PrintParamsObj : public CJS_Object { public: + static int GetObjDefnID(); + static void DefineJSObjects(CFXJS_Engine* pEngine, FXJSOBJTYPE eObjType); + explicit CJS_PrintParamsObj(v8::Local<v8::Object> pObject) : CJS_Object(pObject) {} ~CJS_PrintParamsObj() override {} - static int g_nObjDefnID; - - static void DefineJSObjects(CFXJS_Engine* pEngine, FXJSOBJTYPE eObjType); + private: + static int ObjDefnID; }; struct CJS_AnnotObj; @@ -265,18 +267,15 @@ class Document : public CJS_EmbedObj { class CJS_Document : public CJS_Object { public: + static int GetObjDefnID(); + static void DefineJSObjects(CFXJS_Engine* pEngine, FXJSOBJTYPE eObjType); + explicit CJS_Document(v8::Local<v8::Object> pObject) : CJS_Object(pObject) {} ~CJS_Document() override {} // CJS_Object void InitInstance(IJS_Runtime* pIRuntime) override; - static int g_nObjDefnID; - static JSPropertySpec PropertySpecs[]; - static JSMethodSpec MethodSpecs[]; - - static void DefineJSObjects(CFXJS_Engine* pEngine, FXJSOBJTYPE eObjType); - JS_STATIC_PROP(ADBE, ADBE, Document); JS_STATIC_PROP(author, author, Document); JS_STATIC_PROP(baseURL, base_URL, Document); @@ -352,6 +351,11 @@ class CJS_Document : public CJS_Object { JS_STATIC_METHOD(submitForm, Document); JS_STATIC_METHOD(syncAnnotScan, Document); JS_STATIC_METHOD(mailDoc, Document); + + private: + static int ObjDefnID; + static JSPropertySpec PropertySpecs[]; + static JSMethodSpec MethodSpecs[]; }; #endif // FPDFSDK_JAVASCRIPT_DOCUMENT_H_ |