diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-10-25 13:30:31 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-10-25 18:40:45 +0000 |
| commit | 8f524d6ff9c5c5e07388438e58aca7dc39f43a1f (patch) | |
| tree | ec73d24ebdfb84e0c9a254a35912edc5ab54dae7 /fpdfsdk/javascript/Icon.cpp | |
| parent | 2474a3b2d9fe987dac58813771f1fa66427e124f (diff) | |
| download | pdfium-8f524d6ff9c5c5e07388438e58aca7dc39f43a1f.tar.xz | |
Refactor JS method parameters and return values.
This CL removes the out parameters from the JS methods and changes the
return from a |bool| to a |CJS_Return| value. The return value holds the
returned v8 object, error string and a status code.
Change-Id: I82488ff0d916475d7e3c8e51ed868639806181c9
Reviewed-on: https://pdfium-review.googlesource.com/16751
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fpdfsdk/javascript/Icon.cpp')
| -rw-r--r-- | fpdfsdk/javascript/Icon.cpp | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/fpdfsdk/javascript/Icon.cpp b/fpdfsdk/javascript/Icon.cpp index dbd3e64cb1..2eefaf113c 100644 --- a/fpdfsdk/javascript/Icon.cpp +++ b/fpdfsdk/javascript/Icon.cpp @@ -25,13 +25,10 @@ Icon::Icon(CJS_Object* pJSObject) Icon::~Icon() {} -bool Icon::get_name(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError) { - vp->Set(pRuntime->NewString(m_swIconName.c_str())); - return true; +CJS_Return Icon::get_name(CJS_Runtime* pRuntime) { + return CJS_Return(pRuntime->NewString(m_swIconName.c_str())); } -bool Icon::set_name(CJS_Runtime* pRuntime, - v8::Local<v8::Value> vp, - WideString* sError) { - return false; +CJS_Return Icon::set_name(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp) { + return CJS_Return(false); } |