diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-10-26 15:04:17 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-10-26 19:29:57 +0000 |
| commit | d808dfd5ad8c4eae1f2ea58b9b54a7d4e45a649e (patch) | |
| tree | 26b829d19be342d45fa47accd4a599fb2d5aa711 /fpdfsdk/javascript/Icon.cpp | |
| parent | 977c2a048e02dd3a9563be0c2c6ee62435e134c1 (diff) | |
| download | pdfium-d808dfd5ad8c4eae1f2ea58b9b54a7d4e45a649e.tar.xz | |
Cleanup JS define methods
This CL moves DefineProps, DefineMethods and DefineConsts to the
CJS_Object and removes from the subclasses. The JSConstructor and
JSDestructor are moved to be templated static methods in JS_Defines.
Change-Id: Ibe5ee063a32ae2332b8affc843d97ee6da21f4ee
Reviewed-on: https://pdfium-review.googlesource.com/16930
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fpdfsdk/javascript/Icon.cpp')
| -rw-r--r-- | fpdfsdk/javascript/Icon.cpp | 26 |
1 files changed, 4 insertions, 22 deletions
diff --git a/fpdfsdk/javascript/Icon.cpp b/fpdfsdk/javascript/Icon.cpp index d64878bcc9..ab37e13198 100644 --- a/fpdfsdk/javascript/Icon.cpp +++ b/fpdfsdk/javascript/Icon.cpp @@ -17,29 +17,11 @@ JSPropertySpec CJS_Icon::PropertySpecs[] = { const char* CJS_Icon::g_pClassName = "Icon"; int CJS_Icon::g_nObjDefnID = -1; -void CJS_Icon::JSConstructor(CFXJS_Engine* pEngine, v8::Local<v8::Object> obj) { - CJS_Object* pObj = new CJS_Icon(obj); - pObj->SetEmbedObject(new Icon(pObj)); - pEngine->SetObjectPrivate(obj, pObj); - pObj->InitInstance(static_cast<CJS_Runtime*>(pEngine)); -} - -void CJS_Icon::JSDestructor(CFXJS_Engine* pEngine, v8::Local<v8::Object> obj) { - delete static_cast<CJS_Icon*>(pEngine->GetObjectPrivate(obj)); -} - -void CJS_Icon::DefineProps(CFXJS_Engine* pEngine) { - for (size_t i = 0; i < FX_ArraySize(PropertySpecs) - 1; ++i) { - pEngine->DefineObjProperty(g_nObjDefnID, PropertySpecs[i].pName, - PropertySpecs[i].pPropGet, - PropertySpecs[i].pPropPut); - } -} - void CJS_Icon::DefineJSObjects(CFXJS_Engine* pEngine, FXJSOBJTYPE eObjType) { - g_nObjDefnID = pEngine->DefineObj(CJS_Icon::g_pClassName, eObjType, - JSConstructor, JSDestructor); - DefineProps(pEngine); + g_nObjDefnID = + pEngine->DefineObj(CJS_Icon::g_pClassName, eObjType, + JSConstructor<CJS_Icon, Icon>, JSDestructor<CJS_Icon>); + DefineProps(pEngine, g_nObjDefnID, PropertySpecs); } Icon::Icon(CJS_Object* pJSObject) |