diff options
| author | Tom Sepez <tsepez@chromium.org> | 2017-02-23 09:53:09 -0800 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-02-23 18:32:16 +0000 |
| commit | c6dc69fb69e5d9974aa451d590194d568b78131b (patch) | |
| tree | bec72acd1fee95da7d321ee700cf7aff23ecfe80 /fpdfsdk/javascript/JS_Value.cpp | |
| parent | fc54e054811510c3d7c8a9c6af6c90c3222c7029 (diff) | |
| download | pdfium-c6dc69fb69e5d9974aa451d590194d568b78131b.tar.xz | |
Store JS string constants as single-byte strings.
Save some space since none contain non-ascii characters.
Avoid allocating C++ WideStrings just to convert back to
UTF8 when defining properties.
Change-Id: Id94db21b32ee7a96856c35a09f7550b54599ae13
Reviewed-on: https://pdfium-review.googlesource.com/2826
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fpdfsdk/javascript/JS_Value.cpp')
| -rw-r--r-- | fpdfsdk/javascript/JS_Value.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fpdfsdk/javascript/JS_Value.cpp b/fpdfsdk/javascript/JS_Value.cpp index 7900914a8e..b058847564 100644 --- a/fpdfsdk/javascript/JS_Value.cpp +++ b/fpdfsdk/javascript/JS_Value.cpp @@ -677,8 +677,9 @@ double JS_DateParse(const CFX_WideString& str) { if (v->IsFunction()) { v8::Local<v8::Function> funC = v8::Local<v8::Function>::Cast(v); const int argc = 1; - v8::Local<v8::String> timeStr = - CJS_Runtime::CurrentRuntimeFromIsolate(pIsolate)->WSToJSString(str); + v8::Local<v8::Value> timeStr = + CJS_Runtime::CurrentRuntimeFromIsolate(pIsolate)->NewString( + str.AsStringC()); v8::Local<v8::Value> argv[argc] = {timeStr}; v = funC->Call(context, context->Global(), argc, argv).ToLocalChecked(); if (v->IsNumber()) { |