diff options
| author | tsepez <tsepez@chromium.org> | 2017-01-12 11:21:12 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2017-01-12 11:21:12 -0800 |
| commit | 6cf5ecae75a5cd6fea9ae7f4e28cc28abb3e69c6 (patch) | |
| tree | 07f913aa6847952a32ed787f2861a5099d81cf69 /fpdfsdk/javascript/app.cpp | |
| parent | 192497124e7cde747ade7bf89028586eea293be5 (diff) | |
| download | pdfium-6cf5ecae75a5cd6fea9ae7f4e28cc28abb3e69c6.tar.xz | |
Don't put timers with ID == 0 into the global timer map.
A return of ID == 0 from the embedder means the timer was not
created (see public/fpdf_formfill.h), although few embedders
actually conform to this convention.
Firing a timer with ID == 0 will thus do nothing since there can't
be such a timer in the map.
BUG=679649
Review-Url: https://codereview.chromium.org/2626863003
Diffstat (limited to 'fpdfsdk/javascript/app.cpp')
| -rw-r--r-- | fpdfsdk/javascript/app.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fpdfsdk/javascript/app.cpp b/fpdfsdk/javascript/app.cpp index 80c952d6ca..6562d1b598 100644 --- a/fpdfsdk/javascript/app.cpp +++ b/fpdfsdk/javascript/app.cpp @@ -75,7 +75,8 @@ GlobalTimer::GlobalTimer(app* pObj, m_pFormFillEnv(pFormFillEnv) { CFX_SystemHandler* pHandler = m_pFormFillEnv->GetSysHandler(); m_nTimerID = pHandler->SetTimer(dwElapse, Trigger); - (*GetGlobalTimerMap())[m_nTimerID] = this; + if (m_nTimerID) + (*GetGlobalTimerMap())[m_nTimerID] = this; } GlobalTimer::~GlobalTimer() { |