diff options
author | Dan Sinclair <dsinclair@chromium.org> | 2017-10-26 12:36:18 -0400 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2017-10-26 19:02:37 +0000 |
commit | 977c2a048e02dd3a9563be0c2c6ee62435e134c1 (patch) | |
tree | cba76582cf07dcdf18691a5ba9a4d3c7e949256d /fpdfsdk/javascript/app.cpp | |
parent | 89d26c8ccf336b4f46da2de140313918f2a4ffdf (diff) | |
download | pdfium-977c2a048e02dd3a9563be0c2c6ee62435e134c1.tar.xz |
Remove methods for empty const/method/property arrays
This CL cleans up the methods and arrays for constants, methods and
property definitions which are empty.
Change-Id: I4a4d85cc139075de77d84a40182bd00341c31818
Reviewed-on: https://pdfium-review.googlesource.com/16910
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fpdfsdk/javascript/app.cpp')
-rw-r--r-- | fpdfsdk/javascript/app.cpp | 47 |
1 files changed, 0 insertions, 47 deletions
diff --git a/fpdfsdk/javascript/app.cpp b/fpdfsdk/javascript/app.cpp index 486c74dc8f..84bca4a26d 100644 --- a/fpdfsdk/javascript/app.cpp +++ b/fpdfsdk/javascript/app.cpp @@ -142,25 +142,9 @@ GlobalTimer::TimerMap* GlobalTimer::GetGlobalTimerMap() { return s_TimerMap; } -JSConstSpec CJS_TimerObj::ConstSpecs[] = {{0, JSConstSpec::Number, 0, 0}}; - -JSPropertySpec CJS_TimerObj::PropertySpecs[] = {{0, 0, 0}}; - -JSMethodSpec CJS_TimerObj::MethodSpecs[] = {{0, 0}}; - const char* CJS_TimerObj::g_pClassName = "TimerObj"; int CJS_TimerObj::g_nObjDefnID = -1; -void CJS_TimerObj::DefineConsts(CFXJS_Engine* pEngine) { - for (size_t i = 0; i < FX_ArraySize(ConstSpecs) - 1; ++i) { - pEngine->DefineObjConst( - g_nObjDefnID, ConstSpecs[i].pName, - ConstSpecs[i].eType == JSConstSpec::Number - ? pEngine->NewNumber(ConstSpecs[i].number).As<v8::Value>() - : pEngine->NewString(ConstSpecs[i].pStr).As<v8::Value>()); - } -} - void CJS_TimerObj::JSConstructor(CFXJS_Engine* pEngine, v8::Local<v8::Object> obj) { CJS_Object* pObj = new CJS_TimerObj(obj); @@ -174,28 +158,10 @@ void CJS_TimerObj::JSDestructor(CFXJS_Engine* pEngine, delete static_cast<CJS_TimerObj*>(pEngine->GetObjectPrivate(obj)); } -void CJS_TimerObj::DefineProps(CFXJS_Engine* pEngine) { - for (size_t i = 0; i < FX_ArraySize(PropertySpecs) - 1; ++i) { - pEngine->DefineObjProperty(g_nObjDefnID, PropertySpecs[i].pName, - PropertySpecs[i].pPropGet, - PropertySpecs[i].pPropPut); - } -} - -void CJS_TimerObj::DefineMethods(CFXJS_Engine* pEngine) { - for (size_t i = 0; i < FX_ArraySize(MethodSpecs) - 1; ++i) { - pEngine->DefineObjMethod(g_nObjDefnID, MethodSpecs[i].pName, - MethodSpecs[i].pMethodCall); - } -} - void CJS_TimerObj::DefineJSObjects(CFXJS_Engine* pEngine, FXJSOBJTYPE eObjType) { g_nObjDefnID = pEngine->DefineObj(CJS_TimerObj::g_pClassName, eObjType, JSConstructor, JSDestructor); - DefineConsts(pEngine); - DefineProps(pEngine); - DefineMethods(pEngine); } TimerObj::TimerObj(CJS_Object* pJSObject) @@ -217,8 +183,6 @@ void TimerObj::SetTimer(GlobalTimer* pTimer) { #endif // PDF_ENABLE_XFA #define JS_NUM_FORMSVERSION 7 -JSConstSpec CJS_App::ConstSpecs[] = {{0, JSConstSpec::Number, 0, 0}}; - JSPropertySpec CJS_App::PropertySpecs[] = { {"activeDocs", get_active_docs_static, set_active_docs_static}, {"calculate", get_calculate_static, set_calculate_static}, @@ -262,16 +226,6 @@ JSMethodSpec CJS_App::MethodSpecs[] = {{"alert", alert_static}, const char* CJS_App::g_pClassName = "app"; int CJS_App::g_nObjDefnID = -1; -void CJS_App::DefineConsts(CFXJS_Engine* pEngine) { - for (size_t i = 0; i < FX_ArraySize(ConstSpecs) - 1; ++i) { - pEngine->DefineObjConst( - g_nObjDefnID, ConstSpecs[i].pName, - ConstSpecs[i].eType == JSConstSpec::Number - ? pEngine->NewNumber(ConstSpecs[i].number).As<v8::Value>() - : pEngine->NewString(ConstSpecs[i].pStr).As<v8::Value>()); - } -} - void CJS_App::JSConstructor(CFXJS_Engine* pEngine, v8::Local<v8::Object> obj) { CJS_Object* pObj = new CJS_App(obj); pObj->SetEmbedObject(new app(pObj)); @@ -301,7 +255,6 @@ void CJS_App::DefineMethods(CFXJS_Engine* pEngine) { void CJS_App::DefineJSObjects(CFXJS_Engine* pEngine, FXJSOBJTYPE eObjType) { g_nObjDefnID = pEngine->DefineObj(CJS_App::g_pClassName, eObjType, JSConstructor, JSDestructor); - DefineConsts(pEngine); DefineProps(pEngine); DefineMethods(pEngine); } |