diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-10-26 16:48:30 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-10-26 21:02:17 +0000 |
| commit | ef299534cce8cc42f1bd13665a75947c88195ce0 (patch) | |
| tree | 92e97b4f19dc7d8bdae7c0f43b549ad9d49bcdc4 /fpdfsdk/javascript/cjs_annot.cpp | |
| parent | 15776cf22182e74d8546849780ec0cf61b96ca95 (diff) | |
| download | pdfium-ef299534cce8cc42f1bd13665a75947c88195ce0.tar.xz | |
Cleanup statics in JS classes
This CL removes the static object IDs from each of the CJS_Object
subclasses and moves them to anonymous namespaces. The Spec arrays are
moved to private members of the object classes.
Change-Id: I5dcdb87ef57e4b374b5431580fb55cb75023f8fb
Reviewed-on: https://pdfium-review.googlesource.com/16950
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fpdfsdk/javascript/cjs_annot.cpp')
| -rw-r--r-- | fpdfsdk/javascript/cjs_annot.cpp | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/fpdfsdk/javascript/cjs_annot.cpp b/fpdfsdk/javascript/cjs_annot.cpp index af0d208a1e..27ce8cddec 100644 --- a/fpdfsdk/javascript/cjs_annot.cpp +++ b/fpdfsdk/javascript/cjs_annot.cpp @@ -25,13 +25,19 @@ JSPropertySpec CJS_Annot::PropertySpecs[] = { {"type", get_type_static, set_type_static}, {0, 0, 0}}; -int CJS_Annot::g_nObjDefnID = -1; +int CJS_Annot::ObjDefnID = -1; +// static +int CJS_Annot::GetObjDefnID() { + return ObjDefnID; +} + +// static void CJS_Annot::DefineJSObjects(CFXJS_Engine* pEngine, FXJSOBJTYPE eObjType) { - g_nObjDefnID = + ObjDefnID = pEngine->DefineObj("Annot", eObjType, JSConstructor<CJS_Annot, Annot>, JSDestructor<CJS_Annot>); - DefineProps(pEngine, g_nObjDefnID, PropertySpecs); + DefineProps(pEngine, ObjDefnID, PropertySpecs); } Annot::Annot(CJS_Object* pJSObject) : CJS_EmbedObj(pJSObject) {} |