summaryrefslogtreecommitdiff
path: root/fpdfsdk/javascript/cjs_display.cpp
diff options
context:
space:
mode:
authorDan Sinclair <dsinclair@chromium.org>2017-10-26 15:04:17 -0400
committerChromium commit bot <commit-bot@chromium.org>2017-10-26 19:29:57 +0000
commitd808dfd5ad8c4eae1f2ea58b9b54a7d4e45a649e (patch)
tree26b829d19be342d45fa47accd4a599fb2d5aa711 /fpdfsdk/javascript/cjs_display.cpp
parent977c2a048e02dd3a9563be0c2c6ee62435e134c1 (diff)
downloadpdfium-d808dfd5ad8c4eae1f2ea58b9b54a7d4e45a649e.tar.xz
Cleanup JS define methods
This CL moves DefineProps, DefineMethods and DefineConsts to the CJS_Object and removes from the subclasses. The JSConstructor and JSDestructor are moved to be templated static methods in JS_Defines. Change-Id: Ibe5ee063a32ae2332b8affc843d97ee6da21f4ee Reviewed-on: https://pdfium-review.googlesource.com/16930 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fpdfsdk/javascript/cjs_display.cpp')
-rw-r--r--fpdfsdk/javascript/cjs_display.cpp12
1 files changed, 1 insertions, 11 deletions
diff --git a/fpdfsdk/javascript/cjs_display.cpp b/fpdfsdk/javascript/cjs_display.cpp
index df05ed2671..5d604b55e1 100644
--- a/fpdfsdk/javascript/cjs_display.cpp
+++ b/fpdfsdk/javascript/cjs_display.cpp
@@ -15,18 +15,8 @@ JSConstSpec CJS_Display::ConstSpecs[] = {{"visible", JSConstSpec::Number, 0, 0},
const char* CJS_Display::g_pClassName = "display";
int CJS_Display::g_nObjDefnID = -1;
-void CJS_Display::DefineConsts(CFXJS_Engine* pEngine) {
- for (size_t i = 0; i < FX_ArraySize(ConstSpecs) - 1; ++i) {
- pEngine->DefineObjConst(
- g_nObjDefnID, ConstSpecs[i].pName,
- ConstSpecs[i].eType == JSConstSpec::Number
- ? pEngine->NewNumber(ConstSpecs[i].number).As<v8::Value>()
- : pEngine->NewString(ConstSpecs[i].pStr).As<v8::Value>());
- }
-}
-
void CJS_Display::DefineJSObjects(CFXJS_Engine* pEngine, FXJSOBJTYPE eObjType) {
g_nObjDefnID =
pEngine->DefineObj(CJS_Display::g_pClassName, eObjType, nullptr, nullptr);
- DefineConsts(pEngine);
+ DefineConsts(pEngine, g_nObjDefnID, ConstSpecs);
}