diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-10-26 16:48:30 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-10-26 21:02:17 +0000 |
| commit | ef299534cce8cc42f1bd13665a75947c88195ce0 (patch) | |
| tree | 92e97b4f19dc7d8bdae7c0f43b549ad9d49bcdc4 /fpdfsdk/javascript/cjs_eventhandler.cpp | |
| parent | 15776cf22182e74d8546849780ec0cf61b96ca95 (diff) | |
| download | pdfium-ef299534cce8cc42f1bd13665a75947c88195ce0.tar.xz | |
Cleanup statics in JS classes
This CL removes the static object IDs from each of the CJS_Object
subclasses and moves them to anonymous namespaces. The Spec arrays are
moved to private members of the object classes.
Change-Id: I5dcdb87ef57e4b374b5431580fb55cb75023f8fb
Reviewed-on: https://pdfium-review.googlesource.com/16950
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fpdfsdk/javascript/cjs_eventhandler.cpp')
| -rw-r--r-- | fpdfsdk/javascript/cjs_eventhandler.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fpdfsdk/javascript/cjs_eventhandler.cpp b/fpdfsdk/javascript/cjs_eventhandler.cpp index 03d181be62..f1d37e2091 100644 --- a/fpdfsdk/javascript/cjs_eventhandler.cpp +++ b/fpdfsdk/javascript/cjs_eventhandler.cpp @@ -589,12 +589,12 @@ bool CJS_EventHandler::Shift() { Field* CJS_EventHandler::Source() { CJS_Runtime* pRuntime = m_pJSEventContext->GetJSRuntime(); v8::Local<v8::Object> pDocObj = - pRuntime->NewFxDynamicObj(CJS_Document::g_nObjDefnID); + pRuntime->NewFxDynamicObj(CJS_Document::GetObjDefnID()); if (pDocObj.IsEmpty()) return nullptr; v8::Local<v8::Object> pFieldObj = - pRuntime->NewFxDynamicObj(CJS_Field::g_nObjDefnID); + pRuntime->NewFxDynamicObj(CJS_Field::GetObjDefnID()); if (pFieldObj.IsEmpty()) return nullptr; @@ -616,12 +616,12 @@ Field* CJS_EventHandler::Source() { Field* CJS_EventHandler::Target_Field() { CJS_Runtime* pRuntime = m_pJSEventContext->GetJSRuntime(); v8::Local<v8::Object> pDocObj = - pRuntime->NewFxDynamicObj(CJS_Document::g_nObjDefnID); + pRuntime->NewFxDynamicObj(CJS_Document::GetObjDefnID()); if (pDocObj.IsEmpty()) return nullptr; v8::Local<v8::Object> pFieldObj = - pRuntime->NewFxDynamicObj(CJS_Field::g_nObjDefnID); + pRuntime->NewFxDynamicObj(CJS_Field::GetObjDefnID()); if (pFieldObj.IsEmpty()) return nullptr; |