diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-10-26 16:48:30 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-10-26 21:02:17 +0000 |
| commit | ef299534cce8cc42f1bd13665a75947c88195ce0 (patch) | |
| tree | 92e97b4f19dc7d8bdae7c0f43b549ad9d49bcdc4 /fpdfsdk/javascript/console.cpp | |
| parent | 15776cf22182e74d8546849780ec0cf61b96ca95 (diff) | |
| download | pdfium-ef299534cce8cc42f1bd13665a75947c88195ce0.tar.xz | |
Cleanup statics in JS classes
This CL removes the static object IDs from each of the CJS_Object
subclasses and moves them to anonymous namespaces. The Spec arrays are
moved to private members of the object classes.
Change-Id: I5dcdb87ef57e4b374b5431580fb55cb75023f8fb
Reviewed-on: https://pdfium-review.googlesource.com/16950
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fpdfsdk/javascript/console.cpp')
| -rw-r--r-- | fpdfsdk/javascript/console.cpp | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/fpdfsdk/javascript/console.cpp b/fpdfsdk/javascript/console.cpp index 0f5ca4ea1c..720f5f092e 100644 --- a/fpdfsdk/javascript/console.cpp +++ b/fpdfsdk/javascript/console.cpp @@ -20,13 +20,14 @@ JSMethodSpec CJS_Console::MethodSpecs[] = {{"clear", clear_static}, {"show", show_static}, {0, 0}}; -int CJS_Console::g_nObjDefnID = -1; +int CJS_Console::ObjDefnID = -1; +// static void CJS_Console::DefineJSObjects(CFXJS_Engine* pEngine, FXJSOBJTYPE eObjType) { - g_nObjDefnID = pEngine->DefineObj("console", eObjType, - JSConstructor<CJS_Console, console>, - JSDestructor<CJS_Console>); - DefineMethods(pEngine, g_nObjDefnID, MethodSpecs); + ObjDefnID = pEngine->DefineObj("console", eObjType, + JSConstructor<CJS_Console, console>, + JSDestructor<CJS_Console>); + DefineMethods(pEngine, ObjDefnID, MethodSpecs); } console::console(CJS_Object* pJSObject) : CJS_EmbedObj(pJSObject) {} |