Refactor JS method parameters and return values.

This CL removes the out parameters from the JS methods and changes the
return from a |bool| to a |CJS_Return| value. The return value holds the
returned v8 object, error string and a status code.

Change-Id: I82488ff0d916475d7e3c8e51ed868639806181c9
Reviewed-on: https://pdfium-review.googlesource.com/16751
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

1 files changed, 59 insertions, 108 deletions

diff --git a/fpdfsdk/javascript/event.h b/fpdfsdk/javascript/event.h
index 90b9126c89..ad19e7866f 100644
--- a/fpdfsdk/javascript/event.h
+++ b/fpdfsdk/javascript/event.h
@@ -14,114 +14,65 @@ class event : public CJS_EmbedObj {
   explicit event(CJS_Object* pJSObject);
   ~event() override;
 
- public:
-  bool get_change(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError);
-  bool set_change(CJS_Runtime* pRuntime,
-                  v8::Local<v8::Value> vp,
-                  WideString* sError);
-
-  bool get_change_ex(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError);
-  bool set_change_ex(CJS_Runtime* pRuntime,
-                     v8::Local<v8::Value> vp,
-                     WideString* sError);
-
-  bool get_commit_key(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError);
-  bool set_commit_key(CJS_Runtime* pRuntime,
-                      v8::Local<v8::Value> vp,
-                      WideString* sError);
-
-  bool get_field_full(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError);
-  bool set_field_full(CJS_Runtime* pRuntime,
-                      v8::Local<v8::Value> vp,
-                      WideString* sError);
-
-  bool get_key_down(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError);
-  bool set_key_down(CJS_Runtime* pRuntime,
-                    v8::Local<v8::Value> vp,
-                    WideString* sError);
-
-  bool get_modifier(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError);
-  bool set_modifier(CJS_Runtime* pRuntime,
-                    v8::Local<v8::Value> vp,
-                    WideString* sError);
-
-  bool get_name(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError);
-  bool set_name(CJS_Runtime* pRuntime,
-                v8::Local<v8::Value> vp,
-                WideString* sError);
-
-  bool get_rc(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError);
-  bool set_rc(CJS_Runtime* pRuntime,
-              v8::Local<v8::Value> vp,
-              WideString* sError);
-
-  bool get_rich_change(CJS_Runtime* pRuntime,
-                       CJS_Value* vp,
-                       WideString* sError);
-  bool set_rich_change(CJS_Runtime* pRuntime,
-                       v8::Local<v8::Value> vp,
-                       WideString* sError);
-
-  bool get_rich_change_ex(CJS_Runtime* pRuntime,
-                          CJS_Value* vp,
-                          WideString* sError);
-  bool set_rich_change_ex(CJS_Runtime* pRuntime,
-                          v8::Local<v8::Value> vp,
-                          WideString* sError);
-
-  bool get_rich_value(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError);
-  bool set_rich_value(CJS_Runtime* pRuntime,
-                      v8::Local<v8::Value> vp,
-                      WideString* sError);
-
-  bool get_sel_end(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError);
-  bool set_sel_end(CJS_Runtime* pRuntime,
-                   v8::Local<v8::Value> vp,
-                   WideString* sError);
-
-  bool get_sel_start(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError);
-  bool set_sel_start(CJS_Runtime* pRuntime,
-                     v8::Local<v8::Value> vp,
-                     WideString* sError);
-
-  bool get_shift(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError);
-  bool set_shift(CJS_Runtime* pRuntime,
-                 v8::Local<v8::Value> vp,
-                 WideString* sError);
-
-  bool get_source(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError);
-  bool set_source(CJS_Runtime* pRuntime,
-                  v8::Local<v8::Value> vp,
-                  WideString* sError);
-
-  bool get_target(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError);
-  bool set_target(CJS_Runtime* pRuntime,
-                  v8::Local<v8::Value> vp,
-                  WideString* sError);
-
-  bool get_target_name(CJS_Runtime* pRuntime,
-                       CJS_Value* vp,
-                       WideString* sError);
-  bool set_target_name(CJS_Runtime* pRuntime,
-                       v8::Local<v8::Value> vp,
-                       WideString* sError);
-
-  bool get_type(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError);
-  bool set_type(CJS_Runtime* pRuntime,
-                v8::Local<v8::Value> vp,
-                WideString* sError);
-
-  bool get_value(CJS_Runtime* pRuntime, CJS_Value* vp, WideString* sError);
-  bool set_value(CJS_Runtime* pRuntime,
-                 v8::Local<v8::Value> vp,
-                 WideString* sError);
-
-  bool get_will_commit(CJS_Runtime* pRuntime,
-                       CJS_Value* vp,
-                       WideString* sError);
-  bool set_will_commit(CJS_Runtime* pRuntime,
-                       v8::Local<v8::Value> vp,
-                       WideString* sError);
+  CJS_Return get_change(CJS_Runtime* pRuntime);
+  CJS_Return set_change(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_change_ex(CJS_Runtime* pRuntime);
+  CJS_Return set_change_ex(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_commit_key(CJS_Runtime* pRuntime);
+  CJS_Return set_commit_key(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_field_full(CJS_Runtime* pRuntime);
+  CJS_Return set_field_full(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_key_down(CJS_Runtime* pRuntime);
+  CJS_Return set_key_down(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_modifier(CJS_Runtime* pRuntime);
+  CJS_Return set_modifier(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_name(CJS_Runtime* pRuntime);
+  CJS_Return set_name(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_rc(CJS_Runtime* pRuntime);
+  CJS_Return set_rc(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_rich_change(CJS_Runtime* pRuntime);
+  CJS_Return set_rich_change(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_rich_change_ex(CJS_Runtime* pRuntime);
+  CJS_Return set_rich_change_ex(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_rich_value(CJS_Runtime* pRuntime);
+  CJS_Return set_rich_value(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_sel_end(CJS_Runtime* pRuntime);
+  CJS_Return set_sel_end(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_sel_start(CJS_Runtime* pRuntime);
+  CJS_Return set_sel_start(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_shift(CJS_Runtime* pRuntime);
+  CJS_Return set_shift(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_source(CJS_Runtime* pRuntime);
+  CJS_Return set_source(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_target(CJS_Runtime* pRuntime);
+  CJS_Return set_target(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_target_name(CJS_Runtime* pRuntime);
+  CJS_Return set_target_name(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_type(CJS_Runtime* pRuntime);
+  CJS_Return set_type(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_value(CJS_Runtime* pRuntime);
+  CJS_Return set_value(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
+
+  CJS_Return get_will_commit(CJS_Runtime* pRuntime);
+  CJS_Return set_will_commit(CJS_Runtime* pRuntime, v8::Local<v8::Value> vp);
 };
 
 class CJS_Event : public CJS_Object {