diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-10-26 15:04:17 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-10-26 19:29:57 +0000 |
| commit | d808dfd5ad8c4eae1f2ea58b9b54a7d4e45a649e (patch) | |
| tree | 26b829d19be342d45fa47accd4a599fb2d5aa711 /fpdfsdk/javascript/util.cpp | |
| parent | 977c2a048e02dd3a9563be0c2c6ee62435e134c1 (diff) | |
| download | pdfium-d808dfd5ad8c4eae1f2ea58b9b54a7d4e45a649e.tar.xz | |
Cleanup JS define methods
This CL moves DefineProps, DefineMethods and DefineConsts to the
CJS_Object and removes from the subclasses. The JSConstructor and
JSDestructor are moved to be templated static methods in JS_Defines.
Change-Id: Ibe5ee063a32ae2332b8affc843d97ee6da21f4ee
Reviewed-on: https://pdfium-review.googlesource.com/16930
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fpdfsdk/javascript/util.cpp')
| -rw-r--r-- | fpdfsdk/javascript/util.cpp | 25 |
1 files changed, 4 insertions, 21 deletions
diff --git a/fpdfsdk/javascript/util.cpp b/fpdfsdk/javascript/util.cpp index 08846c18b1..75b0db3141 100644 --- a/fpdfsdk/javascript/util.cpp +++ b/fpdfsdk/javascript/util.cpp @@ -36,28 +36,11 @@ JSMethodSpec CJS_Util::MethodSpecs[] = { const char* CJS_Util::g_pClassName = "util"; int CJS_Util::g_nObjDefnID = -1; -void CJS_Util::JSConstructor(CFXJS_Engine* pEngine, v8::Local<v8::Object> obj) { - CJS_Object* pObj = new CJS_Util(obj); - pObj->SetEmbedObject(new util(pObj)); - pEngine->SetObjectPrivate(obj, pObj); - pObj->InitInstance(static_cast<CJS_Runtime*>(pEngine)); -} - -void CJS_Util::JSDestructor(CFXJS_Engine* pEngine, v8::Local<v8::Object> obj) { - delete static_cast<CJS_Util*>(pEngine->GetObjectPrivate(obj)); -} - -void CJS_Util::DefineMethods(CFXJS_Engine* pEngine) { - for (size_t i = 0; i < FX_ArraySize(MethodSpecs) - 1; ++i) { - pEngine->DefineObjMethod(g_nObjDefnID, MethodSpecs[i].pName, - MethodSpecs[i].pMethodCall); - } -} - void CJS_Util::DefineJSObjects(CFXJS_Engine* pEngine, FXJSOBJTYPE eObjType) { - g_nObjDefnID = pEngine->DefineObj(CJS_Util::g_pClassName, eObjType, - JSConstructor, JSDestructor); - DefineMethods(pEngine); + g_nObjDefnID = + pEngine->DefineObj(CJS_Util::g_pClassName, eObjType, + JSConstructor<CJS_Util, util>, JSDestructor<CJS_Util>); + DefineMethods(pEngine, g_nObjDefnID, MethodSpecs); } namespace { |