diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-07-06 12:11:33 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-07-06 19:41:39 +0000 |
| commit | 1f9d2338feb75d62bb28e116df7243dd567fded8 (patch) | |
| tree | 3828f7c8212bfe30510e0975331060ec020c72d9 /fpdfsdk/pdfwindow/cpwl_combo_box.cpp | |
| parent | 16fea94c94006c25b878ef0acd0bb835397f62bb (diff) | |
| download | pdfium-1f9d2338feb75d62bb28e116df7243dd567fded8.tar.xz | |
Remove in-out param from OnNotifySelChangedchromium/3151
This CL converts OnNotifySelChanged to return instead of accepting an
in-out parameter.
Change-Id: I42ab220b1f3af304493496ada5624677652bf10f
Reviewed-on: https://pdfium-review.googlesource.com/7336
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fpdfsdk/pdfwindow/cpwl_combo_box.cpp')
| -rw-r--r-- | fpdfsdk/pdfwindow/cpwl_combo_box.cpp | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/fpdfsdk/pdfwindow/cpwl_combo_box.cpp b/fpdfsdk/pdfwindow/cpwl_combo_box.cpp index 20cbcd305c..792524b950 100644 --- a/fpdfsdk/pdfwindow/cpwl_combo_box.cpp +++ b/fpdfsdk/pdfwindow/cpwl_combo_box.cpp @@ -40,10 +40,7 @@ bool CPWL_CBListBox::OnLButtonUp(const CFX_PointF& point, uint32_t nFlag) { if (CPWL_Wnd* pParent = GetParentWindow()) pParent->NotifyLButtonUp(this, point); - bool bExit = false; - OnNotifySelChanged(false, bExit, nFlag); - - return !bExit; + return !OnNotifySelChanged(false, nFlag); } bool CPWL_CBListBox::IsMovementKey(uint16_t nChar) const { @@ -83,10 +80,7 @@ bool CPWL_CBListBox::OnMovementKeyDown(uint16_t nChar, uint32_t nFlag) { m_pList->OnVK_RIGHT(IsSHIFTpressed(nFlag), IsCTRLpressed(nFlag)); break; } - - bool bExit = false; - OnNotifySelChanged(true, bExit, nFlag); - return bExit; + return OnNotifySelChanged(true, nFlag); } bool CPWL_CBListBox::IsChar(uint16_t nChar, uint32_t nFlag) const { @@ -97,9 +91,7 @@ bool CPWL_CBListBox::OnCharNotify(uint16_t nChar, uint32_t nFlag) { if (CPWL_ComboBox* pComboBox = (CPWL_ComboBox*)GetParentWindow()) pComboBox->SetSelectText(); - bool bExit = false; - OnNotifySelChanged(true, bExit, nFlag); - return bExit; + return OnNotifySelChanged(true, nFlag); } void CPWL_CBButton::GetThisAppearanceStream(std::ostringstream* psAppStream) { |