diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2016-11-21 13:50:32 -0500 |
|---|---|---|
| committer | dan sinclair <dsinclair@chromium.org> | 2016-11-21 18:51:10 +0000 |
| commit | 85c8e7f788512ce5b5b43cd816e8091b57c3d5e7 (patch) | |
| tree | e727d747684b9db2632ef250b55046cfce2b55a3 /fpdfsdk/pdfwindow | |
| parent | 7daa6fb286d1b5d65f99521f3314083e86d93e3f (diff) | |
| download | pdfium-85c8e7f788512ce5b5b43cd816e8091b57c3d5e7.tar.xz | |
Fixup lint flags.
The -build/include setting was masking out build/include_what_you_use. This CL
restores them, fixes any build errors, and adds NOLINT as needed. As well,
the runtime/explicit and runtime/printf flags are aslo enabled and NOLINT'd.
lint cleanups
Change-Id: Ib013b3eb29c8d0e48cad74c5df9028684130719f
Reviewed-on: https://pdfium-review.googlesource.com/2030
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fpdfsdk/pdfwindow')
| -rw-r--r-- | fpdfsdk/pdfwindow/PWL_EditCtrl.h | 2 | ||||
| -rw-r--r-- | fpdfsdk/pdfwindow/PWL_FontMap.h | 2 | ||||
| -rw-r--r-- | fpdfsdk/pdfwindow/PWL_ListBox.h | 4 | ||||
| -rw-r--r-- | fpdfsdk/pdfwindow/PWL_ScrollBar.h | 2 | ||||
| -rw-r--r-- | fpdfsdk/pdfwindow/PWL_Utils.cpp | 1 |
5 files changed, 8 insertions, 3 deletions
diff --git a/fpdfsdk/pdfwindow/PWL_EditCtrl.h b/fpdfsdk/pdfwindow/PWL_EditCtrl.h index 344d25b72b..3ff5cc66c9 100644 --- a/fpdfsdk/pdfwindow/PWL_EditCtrl.h +++ b/fpdfsdk/pdfwindow/PWL_EditCtrl.h @@ -7,6 +7,8 @@ #ifndef FPDFSDK_PDFWINDOW_PWL_EDITCTRL_H_ #define FPDFSDK_PDFWINDOW_PWL_EDITCTRL_H_ +#include <memory> + #include "core/fxcrt/fx_string.h" #include "fpdfsdk/fxedit/fx_edit.h" #include "fpdfsdk/pdfwindow/PWL_Wnd.h" diff --git a/fpdfsdk/pdfwindow/PWL_FontMap.h b/fpdfsdk/pdfwindow/PWL_FontMap.h index fbf5ee0986..47ef193619 100644 --- a/fpdfsdk/pdfwindow/PWL_FontMap.h +++ b/fpdfsdk/pdfwindow/PWL_FontMap.h @@ -30,7 +30,7 @@ struct CPWL_FontMap_Native { class CPWL_FontMap : public IPVT_FontMap { public: - CPWL_FontMap(CFX_SystemHandler* pSystemHandler); + explicit CPWL_FontMap(CFX_SystemHandler* pSystemHandler); ~CPWL_FontMap() override; // IPVT_FontMap diff --git a/fpdfsdk/pdfwindow/PWL_ListBox.h b/fpdfsdk/pdfwindow/PWL_ListBox.h index 290b8762ef..6db4ecb381 100644 --- a/fpdfsdk/pdfwindow/PWL_ListBox.h +++ b/fpdfsdk/pdfwindow/PWL_ListBox.h @@ -7,6 +7,8 @@ #ifndef FPDFSDK_PDFWINDOW_PWL_LISTBOX_H_ #define FPDFSDK_PDFWINDOW_PWL_LISTBOX_H_ +#include <memory> + #include "fpdfsdk/fxedit/fx_edit.h" #include "fpdfsdk/pdfwindow/PWL_Wnd.h" @@ -20,7 +22,7 @@ struct CPVT_WordProps; class CPWL_List_Notify { public: - CPWL_List_Notify(CPWL_ListBox* pList); + explicit CPWL_List_Notify(CPWL_ListBox* pList); ~CPWL_List_Notify(); void IOnSetScrollInfoY(FX_FLOAT fPlateMin, diff --git a/fpdfsdk/pdfwindow/PWL_ScrollBar.h b/fpdfsdk/pdfwindow/PWL_ScrollBar.h index 19e5151c97..bcfb0a6873 100644 --- a/fpdfsdk/pdfwindow/PWL_ScrollBar.h +++ b/fpdfsdk/pdfwindow/PWL_ScrollBar.h @@ -117,7 +117,7 @@ struct PWL_SCROLL_PRIVATEDATA { class CPWL_ScrollBar : public CPWL_Wnd { public: - CPWL_ScrollBar(PWL_SCROLLBAR_TYPE sbType = SBT_HSCROLL); + explicit CPWL_ScrollBar(PWL_SCROLLBAR_TYPE sbType = SBT_HSCROLL); ~CPWL_ScrollBar() override; // CPWL_Wnd diff --git a/fpdfsdk/pdfwindow/PWL_Utils.cpp b/fpdfsdk/pdfwindow/PWL_Utils.cpp index eb6b3cc221..713a193fb3 100644 --- a/fpdfsdk/pdfwindow/PWL_Utils.cpp +++ b/fpdfsdk/pdfwindow/PWL_Utils.cpp @@ -7,6 +7,7 @@ #include "fpdfsdk/pdfwindow/PWL_Utils.h" #include <algorithm> +#include <memory> #include "core/fpdfdoc/cpvt_word.h" #include "core/fxge/cfx_graphstatedata.h" |