diff options
| author | Tom Sepez <tsepez@chromium.org> | 2017-09-15 13:26:32 -0700 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-09-15 21:25:46 +0000 |
| commit | bf15730b2c9577d4efd2124d84c6c8ccc5f66b43 (patch) | |
| tree | b03fb50d97a3233094437746260c0927464be5ec /fpdfsdk/pwl/cpwl_combo_box.h | |
| parent | bb2f7e73bef47b4e865118cb52170563d849b4de (diff) | |
| download | pdfium-bf15730b2c9577d4efd2124d84c6c8ccc5f66b43.tar.xz | |
Move CPWL_CREATPARAM to CPWL_Wnd::CreateParams
This nesting makes so much more sense when I read the code.
Fix member naming for this in CPWL_Wnd.
Pass in/out CreateParams arg as pointer.
Kill Reset() method, only called during destroy and nothing needs
explicit cleanup.
Change-Id: If50e403e11c131e7656da09c0cb36866223d64c6
Reviewed-on: https://pdfium-review.googlesource.com/14070
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fpdfsdk/pwl/cpwl_combo_box.h')
| -rw-r--r-- | fpdfsdk/pwl/cpwl_combo_box.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/fpdfsdk/pwl/cpwl_combo_box.h b/fpdfsdk/pwl/cpwl_combo_box.h index 7059faccbc..b431191452 100644 --- a/fpdfsdk/pwl/cpwl_combo_box.h +++ b/fpdfsdk/pwl/cpwl_combo_box.h @@ -51,13 +51,13 @@ class CPWL_ComboBox : public CPWL_Wnd { // CPWL_Wnd: CFX_ByteString GetClassName() const override; - void OnCreate(PWL_CREATEPARAM& cp) override; + void OnCreate(CreateParams* pParamsToAdjust) override; void OnDestroy() override; bool OnKeyDown(uint16_t nChar, uint32_t nFlag) override; bool OnChar(uint16_t nChar, uint32_t nFlag) override; void NotifyLButtonDown(CPWL_Wnd* child, const CFX_PointF& pos) override; void NotifyLButtonUp(CPWL_Wnd* child, const CFX_PointF& pos) override; - void CreateChildWnd(const PWL_CREATEPARAM& cp) override; + void CreateChildWnd(const CreateParams& cp) override; void RePosChildWnd() override; CFX_FloatRect GetFocusRect() const override; void SetFocus() override; @@ -84,9 +84,9 @@ class CPWL_ComboBox : public CPWL_Wnd { void AttachFFLData(CFFL_FormFiller* pData) { m_pFormFiller = pData; } private: - void CreateEdit(const PWL_CREATEPARAM& cp); - void CreateButton(const PWL_CREATEPARAM& cp); - void CreateListBox(const PWL_CREATEPARAM& cp); + void CreateEdit(const CreateParams& cp); + void CreateButton(const CreateParams& cp); + void CreateListBox(const CreateParams& cp); void SetPopup(bool bPopup); CFX_UnownedPtr<CPWL_Edit> m_pEdit; |