diff options
author | Lei Zhang <thestig@chromium.org> | 2017-08-12 13:03:44 -0700 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2017-08-15 17:07:10 +0000 |
commit | 3577cfbe59725324b597d2270c94be38d36dab49 (patch) | |
tree | 58352adaca60ecc4befb6d55e8cfd570f859f37e /fpdfsdk/pwl/cpwl_edit.h | |
parent | f5a0667c4dc3fe5a4426cf765e68c1c612fe7633 (diff) | |
download | pdfium-3577cfbe59725324b597d2270c94be38d36dab49.tar.xz |
Do some cleanup in CPWL_Edit.
- Return early in some methods.
- Make IsProceedtoOnChar() a static method.
Change-Id: I56b92d920b2c0bbdff84cb3024d80e379f1c6a2a
Reviewed-on: https://pdfium-review.googlesource.com/10857
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'fpdfsdk/pwl/cpwl_edit.h')
-rw-r--r-- | fpdfsdk/pwl/cpwl_edit.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/fpdfsdk/pwl/cpwl_edit.h b/fpdfsdk/pwl/cpwl_edit.h index 2e92ed2ae7..1c2d9c03bd 100644 --- a/fpdfsdk/pwl/cpwl_edit.h +++ b/fpdfsdk/pwl/cpwl_edit.h @@ -90,7 +90,6 @@ class CPWL_Edit : public CPWL_EditCtrl { m_pFillerNotify = pNotify; } - bool IsProceedtoOnChar(uint16_t nKeyCode, uint32_t nFlag); void AttachFFLData(CFFL_FormFiller* pData) { m_pFormFiller = pData; } void OnInsertWord(const CPVT_WordPlace& place, @@ -104,6 +103,11 @@ class CPWL_Edit : public CPWL_EditCtrl { const CPVT_WordPlace& oldplace); private: + // In case of implementation swallow the OnKeyDown event. If the event is + // swallowed, implementation may do other unexpected things, which is not the + // control means to do. + static bool IsProceedtoOnChar(uint16_t nKeyCode, uint32_t nFlag); + CPVT_WordRange GetSelectWordRange() const; bool IsVScrollBarVisible() const; void SetParamByFlag(); |