summaryrefslogtreecommitdiff
path: root/fpdfsdk/src/fsdk_mgr.cpp
diff options
context:
space:
mode:
authorLei Zhang <thestig@chromium.org>2015-11-02 13:27:54 -0800
committerLei Zhang <thestig@chromium.org>2015-11-02 13:27:54 -0800
commitf0e2e1b09cf1ce0e537888a99f04be6f10edcada (patch)
tree84885b475c64237e2a26668c8a1b4f67421fc51d /fpdfsdk/src/fsdk_mgr.cpp
parentbd55239e7825b8d10255093d8c3fa03b43620a98 (diff)
downloadpdfium-f0e2e1b09cf1ce0e537888a99f04be6f10edcada.tar.xz
XFA: Simplify CPDFSDK_PageView::PageView_OnDraw().
The clip parameter is never NULL. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1417983006 .
Diffstat (limited to 'fpdfsdk/src/fsdk_mgr.cpp')
-rw-r--r--fpdfsdk/src/fsdk_mgr.cpp16
1 files changed, 7 insertions, 9 deletions
diff --git a/fpdfsdk/src/fsdk_mgr.cpp b/fpdfsdk/src/fsdk_mgr.cpp
index f12e8fb595..1b09714dfa 100644
--- a/fpdfsdk/src/fsdk_mgr.cpp
+++ b/fpdfsdk/src/fsdk_mgr.cpp
@@ -654,7 +654,7 @@ CPDFSDK_PageView::~CPDFSDK_PageView() {
void CPDFSDK_PageView::PageView_OnDraw(CFX_RenderDevice* pDevice,
CPDF_Matrix* pUser2Device,
CPDF_RenderOptions* pOptions,
- FX_RECT* pClip) {
+ const FX_RECT& pClip) {
m_curMatrix = *pUser2Device;
CPDFDoc_Environment* pEnv = m_pSDKDoc->GetEnv();
CPDFXFA_Page* pPage = GetPDFXFAPage();
@@ -666,14 +666,12 @@ void CPDFSDK_PageView::PageView_OnDraw(CFX_RenderDevice* pDevice,
if (pPage->GetDocument()->GetDocType() == DOCTYPE_DYNIMIC_XFA) {
CFX_Graphics gs;
gs.Create(pDevice);
- if (pClip) {
- CFX_RectF rectClip;
- rectClip.Set(static_cast<FX_FLOAT>(pClip->left),
- static_cast<FX_FLOAT>(pClip->top),
- static_cast<FX_FLOAT>(pClip->Width()),
- static_cast<FX_FLOAT>(pClip->Height()));
- gs.SetClipRect(rectClip);
- }
+ CFX_RectF rectClip;
+ rectClip.Set(static_cast<FX_FLOAT>(pClip.left),
+ static_cast<FX_FLOAT>(pClip.top),
+ static_cast<FX_FLOAT>(pClip.Width()),
+ static_cast<FX_FLOAT>(pClip.Height()));
+ gs.SetClipRect(rectClip);
IXFA_RenderContext* pRenderContext = XFA_RenderContext_Create();
if (!pRenderContext)
return;