diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-03-02 12:18:50 -0800 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-03-02 12:18:50 -0800 |
| commit | b720d0a14601f1496ef15297bc46d401f5a2a890 (patch) | |
| tree | d19c5604c1528646d992ffcd1beabe8279d5d4b3 /fpdfsdk/src/javascript/console.cpp | |
| parent | 944ccad72d028ed5e37f53c5c8c0888866905bc3 (diff) | |
| download | pdfium-b720d0a14601f1496ef15297bc46d401f5a2a890.tar.xz | |
Return error information from pdfium to JS.
This implements the previously unimplemented JS_Error() function.
Along the way:
- fix some IWYU when the include order in global.cpp was perturbed.
- remove some uses of JS_ErrorString, to increase transparency.
- use vp.IsSetting() in place of !vp.IsGetting() for clarity.
- specify an error string on several error return paths.
- add an error string for writing readonly properties.
- rename an error string constant to reflect the actual message.
- replace calls to variadic Format() with a function doing string appends.
- remove unused JS_GetClassName()
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/963193003
Diffstat (limited to 'fpdfsdk/src/javascript/console.cpp')
| -rw-r--r-- | fpdfsdk/src/javascript/console.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fpdfsdk/src/javascript/console.cpp b/fpdfsdk/src/javascript/console.cpp index d79ac3405d..e8a2c4c4a0 100644 --- a/fpdfsdk/src/javascript/console.cpp +++ b/fpdfsdk/src/javascript/console.cpp @@ -10,9 +10,7 @@ #include "../../include/javascript/JS_Object.h" #include "../../include/javascript/JS_Value.h" #include "../../include/javascript/console.h" -//#include "../../include/javascript/JS_Module.h" #include "../../include/javascript/JS_EventHandler.h" -//#include "../../include/javascript/JS_ResMgr.h" #include "../../include/javascript/JS_Context.h" /* ------------------------ console ------------------------ */ |