diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-08-19 10:42:45 -0700 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-08-19 10:42:45 -0700 |
| commit | 7da980351d6fc428fd95be3015081d911f4470c0 (patch) | |
| tree | 5e0e0dd1e24b770c17bd79397ae097ffd22c5559 /fpdfsdk/src/javascript/global.cpp | |
| parent | 33db790486b89e9a84622788940fd7995e37cf5e (diff) | |
| download | pdfium-7da980351d6fc428fd95be3015081d911f4470c0.tar.xz | |
Merge to XFA: Extern in .cpp files is a code smell, part 1.
(cherry picked from commit 71c15a5e6652952a94ba3a3ef7ac0392e3a06962)
Original Review URL: https://codereview.chromium.org/1299963002 .
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1301073003 .
Diffstat (limited to 'fpdfsdk/src/javascript/global.cpp')
| -rw-r--r-- | fpdfsdk/src/javascript/global.cpp | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/fpdfsdk/src/javascript/global.cpp b/fpdfsdk/src/javascript/global.cpp index dea2b5852c..f8be3687db 100644 --- a/fpdfsdk/src/javascript/global.cpp +++ b/fpdfsdk/src/javascript/global.cpp @@ -39,19 +39,18 @@ struct CHash<ACC, N, Ns...> { static const unsigned value = CHash<CHash<ACC, N>::value, Ns...>::value; }; -extern const unsigned int JSCONST_nStringHash = +const unsigned int JSCONST_nStringHash = CHash<'s', 't', 'r', 'i', 'n', 'g'>::value; -extern const unsigned int JSCONST_nNumberHash = +const unsigned int JSCONST_nNumberHash = CHash<'n', 'u', 'm', 'b', 'e', 'r'>::value; -extern const unsigned int JSCONST_nBoolHash = +const unsigned int JSCONST_nBoolHash = CHash<'b', 'o', 'o', 'l', 'e', 'a', 'n'>::value; -extern const unsigned int JSCONST_nDateHash = CHash<'d', 'a', 't', 'e'>::value; -extern const unsigned int JSCONST_nObjectHash = +const unsigned int JSCONST_nDateHash = CHash<'d', 'a', 't', 'e'>::value; +const unsigned int JSCONST_nObjectHash = CHash<'o', 'b', 'j', 'e', 'c', 't'>::value; -extern const unsigned int JSCONST_nFXobjHash = - CHash<'f', 'x', 'o', 'b', 'j'>::value; -extern const unsigned int JSCONST_nNullHash = CHash<'n', 'u', 'l', 'l'>::value; -extern const unsigned int JSCONST_nUndefHash = +const unsigned int JSCONST_nFXobjHash = CHash<'f', 'x', 'o', 'b', 'j'>::value; +const unsigned int JSCONST_nNullHash = CHash<'n', 'u', 'l', 'l'>::value; +const unsigned int JSCONST_nUndefHash = CHash<'u', 'n', 'd', 'e', 'f', 'i', 'n', 'e', 'd'>::value; #ifdef _DEBUG |