summaryrefslogtreecommitdiff
path: root/fpdfsdk/src/jsapi/fxjs_v8.cpp
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2016-03-04 12:25:33 -0800
committerTom Sepez <tsepez@chromium.org>2016-03-04 12:25:33 -0800
commit3e44a7bd2b60ace1ee8bc8f48c709056f65c3dc1 (patch)
treeda619820b9c96ebca7551fd2135a3dff8925c3e6 /fpdfsdk/src/jsapi/fxjs_v8.cpp
parentdca24838ce9799bd878477f36014525c9d6b645d (diff)
downloadpdfium-3e44a7bd2b60ace1ee8bc8f48c709056f65c3dc1.tar.xz
Only place primitive objects on the V8 global template.
Kill some crummy comments along the way. BUG=pdfium:419 R=jochen@chromium.org Review URL: https://codereview.chromium.org/1759893002 .
Diffstat (limited to 'fpdfsdk/src/jsapi/fxjs_v8.cpp')
-rw-r--r--fpdfsdk/src/jsapi/fxjs_v8.cpp11
1 files changed, 6 insertions, 5 deletions
diff --git a/fpdfsdk/src/jsapi/fxjs_v8.cpp b/fpdfsdk/src/jsapi/fxjs_v8.cpp
index f015f87136..5631ab6258 100644
--- a/fpdfsdk/src/jsapi/fxjs_v8.cpp
+++ b/fpdfsdk/src/jsapi/fxjs_v8.cpp
@@ -287,14 +287,15 @@ void FXJS_DefineGlobalMethod(v8::Isolate* pIsolate,
void FXJS_DefineGlobalConst(v8::Isolate* pIsolate,
const wchar_t* sConstName,
- v8::Local<v8::Value> pDefault) {
+ v8::FunctionCallback pConstGetter) {
v8::Isolate::Scope isolate_scope(pIsolate);
v8::HandleScope handle_scope(pIsolate);
CFX_ByteString bsConst = CFX_WideString(sConstName).UTF8Encode();
- GetGlobalObjectTemplate(pIsolate)->Set(
- v8::String::NewFromUtf8(pIsolate, bsConst.c_str(),
- v8::NewStringType::kNormal).ToLocalChecked(),
- pDefault, v8::ReadOnly);
+ GetGlobalObjectTemplate(pIsolate)
+ ->SetAccessorProperty(v8::String::NewFromUtf8(pIsolate, bsConst.c_str(),
+ v8::NewStringType::kNormal)
+ .ToLocalChecked(),
+ v8::FunctionTemplate::New(pIsolate, pConstGetter));
}
void FXJS_InitializeRuntime(