summaryrefslogtreecommitdiff
path: root/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2015-10-09 13:14:47 -0700
committerTom Sepez <tsepez@chromium.org>2015-10-09 13:14:47 -0700
commit848a13b6777cbff8cc4aea3ab3d69eaa0b82ae6c (patch)
treed2c3a5ee4f67227ac33199f6d10caaf204c92896 /fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp
parentf1c713663192368d26031a4caed1f9705f4510af (diff)
downloadpdfium-848a13b6777cbff8cc4aea3ab3d69eaa0b82ae6c.tar.xz
Pass IJS_Runtime, not IJS_Context, to native object constructors.
This better separates the two IJS_ classes, with the IJS_Context taking on its proper role of describing an event. There's no need for the event details for object creation, so this gets much cleaner. Move some JS error reporting code from CJS_Context to CJS_Runtime. Make InitInstance() and ExitInstance() voids, they always return TRUE and we never check the result anyways. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1389163007 .
Diffstat (limited to 'fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp')
-rw-r--r--fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp b/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp
index 187d611770..b0f3f85167 100644
--- a/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp
+++ b/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp
@@ -32,7 +32,7 @@ class FXJSV8Embeddertest : public EmbedderTest {
v8::Isolate::Scope isolate_scope(m_pIsolate);
v8::HandleScope handle_scope(m_pIsolate);
FXJS_PerIsolateData::SetUp(m_pIsolate);
- FXJS_InitializeRuntime(m_pIsolate, nullptr, nullptr, m_pPersistentContext);
+ FXJS_InitializeRuntime(m_pIsolate, nullptr, m_pPersistentContext);
}
void TearDown() override {
@@ -61,7 +61,7 @@ TEST_F(FXJSV8Embeddertest, Getters) {
FXJSErr error;
CFX_WideString wsInfo;
CFX_WideString wsScript(kScript);
- int sts = FXJS_Execute(isolate(), nullptr, kScript, wcslen(kScript), &error);
+ int sts = FXJS_Execute(isolate(), nullptr, kScript, &error);
EXPECT_EQ(0, sts);
v8::Local<v8::Object> This = FXJS_GetThisObj(isolate());