diff options
| author | Nico Weber <thakis@chromium.org> | 2014-07-30 14:17:19 -0700 |
|---|---|---|
| committer | Nico Weber <thakis@chromium.org> | 2014-07-30 14:17:19 -0700 |
| commit | f1d18bbda1099d9423e09ba4714b3712c1b512d3 (patch) | |
| tree | fbf7b4e497c72925263d7a7685b7b9c1c114fdec /fpdfsdk/src/pdfwindow/PWL_SpecialButton.cpp | |
| parent | fe08482976fb43cc93e4f8a3ea799d98dfe96ada (diff) | |
| download | pdfium-f1d18bbda1099d9423e09ba4714b3712c1b512d3.tar.xz | |
Attempt to fix some -Woverloaded-virtual warnings.
There are many warnings that look like:
error: 'CPWL_RadioButton::OnChar' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
virtual FX_BOOL OnChar(FX_WORD nChar);
^
note: hidden overloaded virtual function 'CPWL_Wnd::OnChar' declared here: different number of parameters (2 vs 1)
virtual FX_BOOL OnChar(FX_WORD nChar, FX_DWORD nFlag);
^
It looks like someone added the nFlag parameter to the methods in CPWL_Wnd
at some point and missed to update all overloads This patch attempts to fix this:
It adds the parameter to all methods that look like they're trying to overload the base
class method, and renames the method in one case where it fairly clearly looks like
that it's not supposed to be an overload.
BUG=pdfium:29
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/416383004
Diffstat (limited to 'fpdfsdk/src/pdfwindow/PWL_SpecialButton.cpp')
| -rw-r--r-- | fpdfsdk/src/pdfwindow/PWL_SpecialButton.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fpdfsdk/src/pdfwindow/PWL_SpecialButton.cpp b/fpdfsdk/src/pdfwindow/PWL_SpecialButton.cpp index 287fec1a55..609beeb2a7 100644 --- a/fpdfsdk/src/pdfwindow/PWL_SpecialButton.cpp +++ b/fpdfsdk/src/pdfwindow/PWL_SpecialButton.cpp @@ -55,7 +55,7 @@ FX_BOOL CPWL_CheckBox::IsChecked() const return m_bChecked; } -FX_BOOL CPWL_CheckBox::OnLButtonUp(const CPDF_Point & point) +FX_BOOL CPWL_CheckBox::OnLButtonUp(const CPDF_Point & point, FX_DWORD nFlag) { if (IsReadOnly()) return FALSE; @@ -63,7 +63,7 @@ FX_BOOL CPWL_CheckBox::OnLButtonUp(const CPDF_Point & point) return TRUE; } -FX_BOOL CPWL_CheckBox::OnChar(FX_WORD nChar) +FX_BOOL CPWL_CheckBox::OnChar(FX_WORD nChar, FX_DWORD nFlag) { SetCheck(!IsChecked()); return TRUE; @@ -84,7 +84,7 @@ CFX_ByteString CPWL_RadioButton::GetClassName() const return "CPWL_RadioButton"; } -FX_BOOL CPWL_RadioButton::OnLButtonUp(const CPDF_Point & point) +FX_BOOL CPWL_RadioButton::OnLButtonUp(const CPDF_Point & point, FX_DWORD nFlag) { if (IsReadOnly()) return FALSE; @@ -102,7 +102,7 @@ FX_BOOL CPWL_RadioButton::IsChecked() const return m_bChecked; } -FX_BOOL CPWL_RadioButton::OnChar(FX_WORD nChar) +FX_BOOL CPWL_RadioButton::OnChar(FX_WORD nChar, FX_DWORD nFlag) { SetCheck(TRUE); return TRUE; |