diff options
| author | Jun Fang <jun_fang@foxitsoftware.com> | 2014-08-18 12:21:44 -0700 |
|---|---|---|
| committer | Jun Fang <jun_fang@foxitsoftware.com> | 2014-08-18 12:21:44 -0700 |
| commit | 39a97eaf1132e9ae6311ef547133b53def0a2cc9 (patch) | |
| tree | a0b3170e5c0010976513be0bc72e9109f57ec33d /fpdfsdk/src | |
| parent | a94019dc7299133ef3dbb075e05e52ac047b67b3 (diff) | |
| download | pdfium-39a97eaf1132e9ae6311ef547133b53def0a2cc9.tar.xz | |
Fix a double-free issue in CFX_PathData::~CFX_PathData
In CPDFSDK_InterForm::SubmitFields, the buffer pointed by m_pBuffer is returned
and released by the caller. However, it will be released again in the destructor.
BUG=401580
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/481733002
Diffstat (limited to 'fpdfsdk/src')
| -rw-r--r-- | fpdfsdk/src/fsdk_baseform.cpp | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/fpdfsdk/src/fsdk_baseform.cpp b/fpdfsdk/src/fsdk_baseform.cpp index ae3b6364d3..aa87dd56bb 100644 --- a/fpdfsdk/src/fsdk_baseform.cpp +++ b/fpdfsdk/src/fsdk_baseform.cpp @@ -2284,12 +2284,6 @@ FX_BOOL CPDFSDK_InterForm::SubmitFields(const CFX_WideString& csDestination, con pEnv->JS_docSubmitForm(pBuffer, nBufSize, (FX_LPCWSTR)csDestination); - if (bUrlEncoded && pBuffer) - { - FX_Free(pBuffer); - pBuffer = NULL; - } - return TRUE; } |