summaryrefslogtreecommitdiff
path: root/fpdfsdk/src
diff options
context:
space:
mode:
authorLei Zhang <thestig@chromium.org>2015-12-28 13:07:50 -0800
committerLei Zhang <thestig@chromium.org>2015-12-28 13:07:50 -0800
commitde0387c3690ca147482ed943c70eeb828b6dd732 (patch)
tree7dc479d89d2b30c58cb54f2ff8dc2ab070fc4b2e /fpdfsdk/src
parent1f1c1970259b696a9b1e5ca1a3c199f221846409 (diff)
downloadpdfium-de0387c3690ca147482ed943c70eeb828b6dd732.tar.xz
Take care fall-through cases of switch in pdfium
Found with Clang's -Wimplicit-fallthrough option by tzik@chromium.org. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1549283002 .
Diffstat (limited to 'fpdfsdk/src')
-rw-r--r--fpdfsdk/src/formfiller/FFL_FormFiller.cpp2
-rw-r--r--fpdfsdk/src/javascript/JS_GlobalData.cpp4
2 files changed, 4 insertions, 2 deletions
diff --git a/fpdfsdk/src/formfiller/FFL_FormFiller.cpp b/fpdfsdk/src/formfiller/FFL_FormFiller.cpp
index 2e0451c0f6..ae99edbf87 100644
--- a/fpdfsdk/src/formfiller/FFL_FormFiller.cpp
+++ b/fpdfsdk/src/formfiller/FFL_FormFiller.cpp
@@ -273,8 +273,10 @@ void CFFL_FormFiller::KillFocusForAnnot(CPDFSDK_Annot* pAnnot, FX_UINT nFlag) {
case FIELDTYPE_CHECKBOX:
case FIELDTYPE_RADIOBUTTON:
bDestroyPDFWindow = TRUE;
+ break;
default:
bDestroyPDFWindow = FALSE;
+ break;
}
EscapeFiller(pPageView, bDestroyPDFWindow);
}
diff --git a/fpdfsdk/src/javascript/JS_GlobalData.cpp b/fpdfsdk/src/javascript/JS_GlobalData.cpp
index 474886c484..4d6edc898d 100644
--- a/fpdfsdk/src/javascript/JS_GlobalData.cpp
+++ b/fpdfsdk/src/javascript/JS_GlobalData.cpp
@@ -51,13 +51,13 @@ void CJS_GlobalVariableArray::Copy(const CJS_GlobalVariableArray& array) {
pNewObjData->nType = pOldObjData->nType;
pNewObjData->objData.Copy(pOldObjData->objData);
Add(pNewObjData);
- }
+ } break;
case JS_GLOBALDATA_TYPE_NULL: {
CJS_KeyValue* pNewObjData = new CJS_KeyValue;
pNewObjData->sKey = pOldObjData->sKey;
pNewObjData->nType = pOldObjData->nType;
Add(pNewObjData);
- }
+ } break;
}
}
}