diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-08-19 13:25:44 -0700 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-08-19 13:25:44 -0700 |
| commit | c3f4894a6862c74b9ab32b4ec38c531de6ecd83c (patch) | |
| tree | f5ad333e8d418d5a978a595f51e94b3ad8f365da /fpdfsdk | |
| parent | 71c15a5e6652952a94ba3a3ef7ac0392e3a06962 (diff) | |
| download | pdfium-c3f4894a6862c74b9ab32b4ec38c531de6ecd83c.tar.xz | |
Extern in .cpp file is a code smell, part 2.
Fixes the remaining issues, except for JBIG2/Skia ...
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1298393003 .
Diffstat (limited to 'fpdfsdk')
| -rw-r--r-- | fpdfsdk/include/fsdk_define.h | 1 | ||||
| -rw-r--r-- | fpdfsdk/include/fxedit/fx_edit.h | 5 | ||||
| -rw-r--r-- | fpdfsdk/src/fpdf_dataavail.cpp | 1 | ||||
| -rw-r--r-- | fpdfsdk/src/fpdfview.cpp | 4 | ||||
| -rw-r--r-- | fpdfsdk/src/fxedit/fxet_pageobjs.cpp | 5 |
5 files changed, 6 insertions, 10 deletions
diff --git a/fpdfsdk/include/fsdk_define.h b/fpdfsdk/include/fsdk_define.h index 987b00f6f0..d2af1e17f7 100644 --- a/fpdfsdk/include/fsdk_define.h +++ b/fpdfsdk/include/fsdk_define.h @@ -74,5 +74,6 @@ void FPDF_RenderPage_Retail(CRenderContext* pContext, void CheckUnSupportError(CPDF_Document* pDoc, FX_DWORD err_code); void CheckUnSupportAnnot(CPDF_Document* pDoc, CPDF_Annot* pPDFAnnot); +void ProcessParseError(FX_DWORD err_code); #endif // FPDFSDK_INCLUDE_FSDK_DEFINE_H_ diff --git a/fpdfsdk/include/fxedit/fx_edit.h b/fpdfsdk/include/fxedit/fx_edit.h index 4f8b2fbd67..23acbfa79f 100644 --- a/fpdfsdk/include/fxedit/fx_edit.h +++ b/fpdfsdk/include/fxedit/fx_edit.h @@ -568,4 +568,9 @@ class IFX_List { virtual ~IFX_List() {} }; +CFX_ByteString GetPDFWordString(IFX_Edit_FontMap* pFontMap, + int32_t nFontIndex, + FX_WORD Word, + FX_WORD SubWord); + #endif // FPDFSDK_INCLUDE_FXEDIT_FX_EDIT_H_ diff --git a/fpdfsdk/src/fpdf_dataavail.cpp b/fpdfsdk/src/fpdf_dataavail.cpp index dddf9afb08..9ce298d0c5 100644 --- a/fpdfsdk/src/fpdf_dataavail.cpp +++ b/fpdfsdk/src/fpdf_dataavail.cpp @@ -7,7 +7,6 @@ #include "../../public/fpdf_dataavail.h" #include "../include/fsdk_define.h" -extern void ProcessParseError(FX_DWORD err_code); class CFPDF_FileAvailWrap : public IFX_FileAvail { public: CFPDF_FileAvailWrap() { m_pfileAvail = NULL; } diff --git a/fpdfsdk/src/fpdfview.cpp b/fpdfsdk/src/fpdfview.cpp index bed00d3172..3603af6d91 100644 --- a/fpdfsdk/src/fpdfview.cpp +++ b/fpdfsdk/src/fpdfview.cpp @@ -61,10 +61,6 @@ FPDF_BOOL FSDK_IsSandBoxPolicyEnabled(FPDF_DWORD policy) { } } -#ifndef _T -#define _T(x) x -#endif - CCodec_ModuleMgr* g_pCodecModule = nullptr; #if _FX_OS_ == _FX_LINUX_EMBEDDED_ diff --git a/fpdfsdk/src/fxedit/fxet_pageobjs.cpp b/fpdfsdk/src/fxedit/fxet_pageobjs.cpp index 1fb669bb57..9c18943a81 100644 --- a/fpdfsdk/src/fxedit/fxet_pageobjs.cpp +++ b/fpdfsdk/src/fxedit/fxet_pageobjs.cpp @@ -11,11 +11,6 @@ #define FX_EDIT_UNDERLINEHALFWIDTH 0.5f #define FX_EDIT_CROSSOUTHALFWIDTH 0.5f -extern CFX_ByteString GetPDFWordString(IFX_Edit_FontMap* pFontMap, - int32_t nFontIndex, - FX_WORD Word, - FX_WORD SubWord); - CPDF_Rect GetUnderLineRect(const CPVT_Word& word) { return CPDF_Rect(word.ptWord.x, word.ptWord.y + word.fDescent * 0.5f, word.ptWord.x + word.fWidth, |