summaryrefslogtreecommitdiff
path: root/fpdfsdk
diff options
context:
space:
mode:
authortsepez <tsepez@chromium.org>2016-05-19 15:55:11 -0700
committerCommit bot <commit-bot@chromium.org>2016-05-19 15:55:11 -0700
commit39faf4fde606fa3b71d2b6b232cff3e86cb1303f (patch)
treeb300d80918177d7f4dd5e4fd40de37f78f6bc574 /fpdfsdk
parent9b1a0ee2a8f24411609a2f7554119597950dbd04 (diff)
downloadpdfium-39faf4fde606fa3b71d2b6b232cff3e86cb1303f.tar.xz
Remove Release() from CPDFDOC_Environment
It's never called. But looking at the comments in fpdf_formfill.h for the Release callback, it seems like it should always be called as part of the dtor. BUG= Review-Url: https://codereview.chromium.org/1995753004
Diffstat (limited to 'fpdfsdk')
-rw-r--r--fpdfsdk/fsdk_mgr.cpp2
-rw-r--r--fpdfsdk/include/fsdk_mgr.h8
2 files changed, 2 insertions, 8 deletions
diff --git a/fpdfsdk/fsdk_mgr.cpp b/fpdfsdk/fsdk_mgr.cpp
index 3f957c7f3f..e4ceadc43c 100644
--- a/fpdfsdk/fsdk_mgr.cpp
+++ b/fpdfsdk/fsdk_mgr.cpp
@@ -51,6 +51,8 @@ CPDFDoc_Environment::~CPDFDoc_Environment() {
if (pProvider->m_pEnvList.GetSize() == 0)
pProvider->SetJavaScriptInitialized(FALSE);
#endif // PDF_ENABLE_XFA
+ if (m_pInfo && m_pInfo->Release)
+ m_pInfo->Release(m_pInfo);
}
int CPDFDoc_Environment::JS_appAlert(const FX_WCHAR* Msg,
diff --git a/fpdfsdk/include/fsdk_mgr.h b/fpdfsdk/include/fsdk_mgr.h
index cd89a925ab..ca46a069f1 100644
--- a/fpdfsdk/include/fsdk_mgr.h
+++ b/fpdfsdk/include/fsdk_mgr.h
@@ -40,14 +40,6 @@ class CPDFDoc_Environment final {
CPDFDoc_Environment(UnderlyingDocumentType* pDoc, FPDF_FORMFILLINFO* pFFinfo);
~CPDFDoc_Environment();
-#ifdef PDF_ENABLE_XFA
- void Release() {
- if (m_pInfo && m_pInfo->Release)
- m_pInfo->Release(m_pInfo);
- delete this;
- }
-#endif // PDF_ENABLE_XFA
-
void FFI_Invalidate(FPDF_PAGE page,
double left,
double top,