Fixing whitespace lint errors.

This CL enables several of the diabled whitelist/* lint checks.

R=thestig@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/1730553002 .

9 files changed, 14 insertions, 38 deletions

diff --git a/fpdfsdk/include/fsdk_baseform.h b/fpdfsdk/include/fsdk_baseform.h
index e23d34ca81..44ba5726a4 100644
--- a/fpdfsdk/include/fsdk_baseform.h
+++ b/fpdfsdk/include/fsdk_baseform.h
@@ -210,9 +210,7 @@ class CPDFSDK_Widget : public CPDFSDK_BAAnnot {
 
   FX_BOOL HitTest(FX_FLOAT pageX, FX_FLOAT pageY);
 
-#ifndef PDF_ENABLE_XFA
  private:
-#endif  // PDF_ENABLE_XFA
   CPDFSDK_InterForm* m_pInterForm;
   FX_BOOL m_bAppModified;
   int32_t m_nAppAge;
diff --git a/fpdfsdk/src/fpdftext.cpp b/fpdfsdk/src/fpdftext.cpp
index c745c26868..80d56920bc 100644
--- a/fpdfsdk/src/fpdftext.cpp
+++ b/fpdfsdk/src/fpdftext.cpp
@@ -183,7 +183,7 @@ DLLEXPORT int STDCALL FPDFText_GetBoundedText(FPDF_TEXTPAGE text_page,
 }
 
 // Search
-//-1 for end
+// -1 for end
 DLLEXPORT FPDF_SCHHANDLE STDCALL FPDFText_FindStart(FPDF_TEXTPAGE text_page,
                                                     FPDF_WIDESTRING findwhat,
                                                     unsigned long flags,
diff --git a/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp b/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
index 7bea8b65c9..2baef4c21b 100644
--- a/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
+++ b/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
@@ -698,7 +698,7 @@ void CPDFXFA_Document::ExportData(IXFA_Doc* hDoc,
 }
 void CPDFXFA_Document::ImportData(IXFA_Doc* hDoc,
                                   const CFX_WideStringC& wsFilePath) {
-  // TODO...
+  // TODO ...
 }
 
 void CPDFXFA_Document::GotoURL(IXFA_Doc* hDoc,
diff --git a/fpdfsdk/src/javascript/JS_Define.h b/fpdfsdk/src/javascript/JS_Define.h
index 3b45ea20a1..f03d9ec7fc 100644
--- a/fpdfsdk/src/javascript/JS_Define.h
+++ b/fpdfsdk/src/javascript/JS_Define.h
@@ -44,7 +44,7 @@ struct JSMethodSpec {
 #define END_JS_STATIC_CONST() \
   { 0, 0, 0, 0 }              \
   }                           \
-  ;
+  ;  // NOLINT
 
 #define BEGIN_JS_STATIC_PROP(js_class_name) \
   JSPropertySpec js_class_name::JS_Class_Properties[] = {
@@ -58,7 +58,7 @@ struct JSMethodSpec {
 #define END_JS_STATIC_PROP() \
   { 0, 0, 0 }                \
   }                          \
-  ;
+  ;  // NOLINT
 
 #define BEGIN_JS_STATIC_METHOD(js_class_name) \
   JSMethodSpec js_class_name::JS_Class_Methods[] = {
@@ -69,7 +69,7 @@ struct JSMethodSpec {
 #define END_JS_STATIC_METHOD() \
   { 0, 0 }                     \
   }                            \
-  ;
+  ;  // NOLINT
 
 template <class C,
           FX_BOOL (C::*M)(IJS_Context*, CJS_PropValue&, CFX_WideString&)>
diff --git a/fpdfsdk/src/javascript/JS_Value.cpp b/fpdfsdk/src/javascript/JS_Value.cpp
index 17b0d8738d..9f27387d1d 100644
--- a/fpdfsdk/src/javascript/JS_Value.cpp
+++ b/fpdfsdk/src/javascript/JS_Value.cpp
@@ -274,12 +274,6 @@ FX_BOOL CJS_Value::ConvertToArray(CJS_Array& array) const {
 }
 
 FX_BOOL CJS_Value::ConvertToDate(CJS_Date& date) const {
-  // 	if (GetType() == VT_date)
-  // 	{
-  // 		date = (double)(*this);
-  // 		return TRUE;
-  // 	}
-
   if (IsDateObject()) {
     date.Attach(m_pValue);
     return TRUE;
diff --git a/fpdfsdk/src/javascript/event.cpp b/fpdfsdk/src/javascript/event.cpp
index f0f52f77cc..f964908b9b 100644
--- a/fpdfsdk/src/javascript/event.cpp
+++ b/fpdfsdk/src/javascript/event.cpp
@@ -172,33 +172,18 @@ FX_BOOL event::richChange(IJS_Context* cc,
                           CJS_PropValue& vp,
                           CFX_WideString& sError) {
   return TRUE;
-  if (vp.IsSetting()) {
-  } else {
-    ;
-  }
-  return TRUE;
 }
 
 FX_BOOL event::richChangeEx(IJS_Context* cc,
                             CJS_PropValue& vp,
                             CFX_WideString& sError) {
   return TRUE;
-  if (vp.IsSetting()) {
-  } else {
-    ;
-  }
-  return TRUE;
 }
 
 FX_BOOL event::richValue(IJS_Context* cc,
                          CJS_PropValue& vp,
                          CFX_WideString& sError) {
   return TRUE;
-  if (vp.IsSetting()) {
-  } else {
-    ;
-  }
-  return TRUE;
 }
 
 FX_BOOL event::selEnd(IJS_Context* cc,
diff --git a/fpdfsdk/src/javascript/global.cpp b/fpdfsdk/src/javascript/global.cpp
index e464339176..fdd67553fc 100644
--- a/fpdfsdk/src/javascript/global.cpp
+++ b/fpdfsdk/src/javascript/global.cpp
@@ -264,7 +264,6 @@ void JSGlobalAlternate::UpdateGlobalPersistentVariables() {
                            false, "", pObj, pData->bPersistent == 1);
         FXJS_PutObjectObject(NULL, m_pJSObject->ToV8Object(),
                              pData->data.sKey.UTF8Decode().c_str(), pObj);
-
       } break;
       case JS_GLOBALDATA_TYPE_NULL:
         SetGlobalVariables(pData->data.sKey, JS_GLOBALDATA_TYPE_NULL, 0, false,
diff --git a/fpdfsdk/src/javascript/util.cpp b/fpdfsdk/src/javascript/util.cpp
index fd08d49883..4bc28cd03a 100644
--- a/fpdfsdk/src/javascript/util.cpp
+++ b/fpdfsdk/src/javascript/util.cpp
@@ -53,23 +53,23 @@ const stru_TbConvert fcTable[] = {
     {L"mmmm", L"%B"},
     {L"mmm", L"%b"},
     {L"mm", L"%m"},
-    //"m"
+    // "m"
     {L"dddd", L"%A"},
     {L"ddd", L"%a"},
     {L"dd", L"%d"},
-    //"d",   "%w",
+    // "d",   "%w",
     {L"yyyy", L"%Y"},
     {L"yy", L"%y"},
     {L"HH", L"%H"},
-    //"H"
+    // "H"
     {L"hh", L"%I"},
-    //"h"
+    // "h"
     {L"MM", L"%M"},
-    //"M"
+    // "M"
     {L"ss", L"%S"},
-    //"s
+    // "s
     {L"TT", L"%p"},
-//"t"
+// "t"
 #if defined(_WIN32)
     {L"tt", L"%p"},
     {L"h", L"%#I"},
diff --git a/fpdfsdk/src/pdfwindow/PWL_Edit.cpp b/fpdfsdk/src/pdfwindow/PWL_Edit.cpp
index ce9274aeb9..7834473ded 100644
--- a/fpdfsdk/src/pdfwindow/PWL_Edit.cpp
+++ b/fpdfsdk/src/pdfwindow/PWL_Edit.cpp
@@ -82,7 +82,7 @@ void CPWL_Edit::RePosChildWnd() {
 
   if (m_pEditCaret && !HasFlag(PES_TEXTOVERFLOW))
     m_pEditCaret->SetClipRect(CPWL_Utils::InflateRect(
-        GetClientRect(), 1.0f));  //+1 for caret beside border
+        GetClientRect(), 1.0f));  // +1 for caret beside border
 
   CPWL_EditCtrl::RePosChildWnd();
 }
@@ -239,7 +239,7 @@ void CPWL_Edit::SetParamByFlag() {
   } else {
     if (m_pEditCaret) {
       m_pEditCaret->SetClipRect(CPWL_Utils::InflateRect(
-          GetClientRect(), 1.0f));  //+1 for caret beside border
+          GetClientRect(), 1.0f));  // +1 for caret beside border
     }
   }