diff options
| author | Tom Sepez <tsepez@chromium.org> | 2015-10-07 13:09:38 -0700 |
|---|---|---|
| committer | Tom Sepez <tsepez@chromium.org> | 2015-10-07 13:09:38 -0700 |
| commit | 7fed2e7b5df7897abf365745ad688aab4bdfdf5a (patch) | |
| tree | f9a30fcb6c2c0cf7ad4a79a0d25249f036600d16 /fpdfsdk | |
| parent | a72e8e2c4392df725c7e35ed1ae3f891e79e49ec (diff) | |
| download | pdfium-7fed2e7b5df7897abf365745ad688aab4bdfdf5a.tar.xz | |
Merge to XFA: Remove unused global argument from FXJS_CONSTRUCTOR.
(cherry picked from commit ebd39a6a8fcbbbf1c5a2e6f1b2e30f452971d0ee)
Original Review URL: https://codereview.chromium.org/1389003003 .
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1394023002 .
Diffstat (limited to 'fpdfsdk')
| -rw-r--r-- | fpdfsdk/include/jsapi/fxjs_v8.h | 4 | ||||
| -rw-r--r-- | fpdfsdk/src/javascript/JS_Define.h | 16 | ||||
| -rw-r--r-- | fpdfsdk/src/jsapi/fxjs_v8.cpp | 10 |
3 files changed, 10 insertions, 20 deletions
diff --git a/fpdfsdk/include/jsapi/fxjs_v8.h b/fpdfsdk/include/jsapi/fxjs_v8.h index 6e8d2fa478..750d7a8fae 100644 --- a/fpdfsdk/include/jsapi/fxjs_v8.h +++ b/fpdfsdk/include/jsapi/fxjs_v8.h @@ -62,9 +62,7 @@ class FXJS_ArrayBufferAllocator : public v8::ArrayBuffer::Allocator { void Free(void* data, size_t length) override; }; -using FXJS_CONSTRUCTOR = void (*)(IFXJS_Context* cc, - v8::Local<v8::Object> obj, - v8::Local<v8::Object> global); +using FXJS_CONSTRUCTOR = void (*)(IFXJS_Context* cc, v8::Local<v8::Object> obj); using FXJS_DESTRUCTOR = void (*)(v8::Local<v8::Object> obj); // Call before making FXJS_PrepareIsolate call. diff --git a/fpdfsdk/src/javascript/JS_Define.h b/fpdfsdk/src/javascript/JS_Define.h index cb0986dd3b..eaad4708d8 100644 --- a/fpdfsdk/src/javascript/JS_Define.h +++ b/fpdfsdk/src/javascript/JS_Define.h @@ -242,20 +242,18 @@ void JSMethod(const char* method_name_string, DefineMethods(pIsolate); \ } -#define DECLARE_JS_CLASS_RICH_PART() \ - static void JSConstructor(IFXJS_Context* cc, v8::Local<v8::Object> obj, \ - v8::Local<v8::Object> global); \ - static void JSDestructor(v8::Local<v8::Object> obj); \ - static void DefineProps(v8::Isolate* pIsoalte); \ - static void DefineMethods(v8::Isolate* pIsoalte); \ - static JSPropertySpec JS_Class_Properties[]; \ +#define DECLARE_JS_CLASS_RICH_PART() \ + static void JSConstructor(IFXJS_Context* cc, v8::Local<v8::Object> obj); \ + static void JSDestructor(v8::Local<v8::Object> obj); \ + static void DefineProps(v8::Isolate* pIsoalte); \ + static void DefineMethods(v8::Isolate* pIsoalte); \ + static JSPropertySpec JS_Class_Properties[]; \ static JSMethodSpec JS_Class_Methods[]; #define IMPLEMENT_JS_CLASS_RICH_PART(js_class_name, class_alternate, \ class_name) \ void js_class_name::JSConstructor(IFXJS_Context* cc, \ - v8::Local<v8::Object> obj, \ - v8::Local<v8::Object> global) { \ + v8::Local<v8::Object> obj) { \ CJS_Object* pObj = new js_class_name(obj); \ pObj->SetEmbedObject(new class_alternate(pObj)); \ FXJS_SetPrivate(nullptr, obj, (void*)pObj); \ diff --git a/fpdfsdk/src/jsapi/fxjs_v8.cpp b/fpdfsdk/src/jsapi/fxjs_v8.cpp index 0be7cc01e2..9f86e0e839 100644 --- a/fpdfsdk/src/jsapi/fxjs_v8.cpp +++ b/fpdfsdk/src/jsapi/fxjs_v8.cpp @@ -293,11 +293,7 @@ void FXJS_InitializeRuntime(v8::Isolate* pIsolate, pObjDef->m_pConstructor(context, v8Context->Global() ->GetPrototype() ->ToObject(v8Context) - .ToLocalChecked(), - v8Context->Global() - ->GetPrototype() - ->ToObject(v8Context) - .ToLocalChecked()); + .ToLocalChecked()); } else if (pObjDef->m_ObjType == FXJSOBJTYPE_STATIC) { v8::Local<v8::Object> obj = FXJS_NewFxDynamicObj(pIsolate, context, i); v8Context->Global()->Set(v8Context, m_ObjName, obj).FromJust(); @@ -403,9 +399,7 @@ v8::Local<v8::Object> FXJS_NewFxDynamicObj(v8::Isolate* pIsolate, obj->SetAlignedPointerInInternalField(0, new CFXJS_PrivateData(nObjDefnID)); if (pObjDef->m_pConstructor) - pObjDef->m_pConstructor( - pJSContext, obj, - context->Global()->GetPrototype()->ToObject(context).ToLocalChecked()); + pObjDef->m_pConstructor(pJSContext, obj); return obj; } |