diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-06-22 17:46:05 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-06-22 17:46:05 +0000 |
| commit | 9fff1c76c1083a5cc0543911811e36007a38aa3a (patch) | |
| tree | d7769c918bdf41a572d3869c5f2e3982636b50a0 /fpdfsdk | |
| parent | e6ca7c2d7d45bd59d53c3c6f9952e2001cf81890 (diff) | |
| download | pdfium-9fff1c76c1083a5cc0543911811e36007a38aa3a.tar.xz | |
Avoid some duplicate const/non-const getters.
Getters should nearly always be const when they return a
non-const pointer to an unowned object. Saves a bit of
code along the way.
Grep for similar occurrences and add "const".
Change-Id: I492bf962a7d62452fa40310146226dc0c8ebb753
Reviewed-on: https://pdfium-review.googlesource.com/35890
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'fpdfsdk')
| -rw-r--r-- | fpdfsdk/cpdfsdk_formfillenvironment.h | 2 | ||||
| -rw-r--r-- | fpdfsdk/formfiller/cffl_formfiller.h | 2 | ||||
| -rw-r--r-- | fpdfsdk/fpdfxfa/cpdfxfa_context.h | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/fpdfsdk/cpdfsdk_formfillenvironment.h b/fpdfsdk/cpdfsdk_formfillenvironment.h index b0512485dd..dacc02f95d 100644 --- a/fpdfsdk/cpdfsdk_formfillenvironment.h +++ b/fpdfsdk/cpdfsdk_formfillenvironment.h @@ -66,7 +66,7 @@ class CPDFSDK_FormFillEnvironment void RemovePageView(IPDF_Page* pPage); void UpdateAllViews(CPDFSDK_PageView* pSender, CPDFSDK_Annot* pAnnot); - CPDFSDK_Annot* GetFocusAnnot() { return m_pFocusAnnot.Get(); } + CPDFSDK_Annot* GetFocusAnnot() const { return m_pFocusAnnot.Get(); } bool SetFocusAnnot(CPDFSDK_Annot::ObservedPtr* pAnnot); bool KillFocusAnnot(uint32_t nFlag); void ClearAllFocusedAnnots(); diff --git a/fpdfsdk/formfiller/cffl_formfiller.h b/fpdfsdk/formfiller/cffl_formfiller.h index bad42ecaf4..95f5ac8427 100644 --- a/fpdfsdk/formfiller/cffl_formfiller.h +++ b/fpdfsdk/formfiller/cffl_formfiller.h @@ -143,7 +143,7 @@ class CFFL_FormFiller : public CPWL_Wnd::ProviderIface, CPDFSDK_PageView* GetCurPageView(bool renew); void SetChangeMark(); - CPDFSDK_Annot* GetSDKAnnot() { return m_pWidget.Get(); } + CPDFSDK_Annot* GetSDKAnnot() const { return m_pWidget.Get(); } protected: using CFFL_PageView2PDFWindow = std::map<CPDFSDK_PageView*, CPWL_Wnd*>; diff --git a/fpdfsdk/fpdfxfa/cpdfxfa_context.h b/fpdfsdk/fpdfxfa/cpdfxfa_context.h index 54b2cac349..45ad447c5a 100644 --- a/fpdfsdk/fpdfxfa/cpdfxfa_context.h +++ b/fpdfsdk/fpdfxfa/cpdfxfa_context.h @@ -41,7 +41,7 @@ class CPDFXFA_Context : public CPDF_Document::Extension, bool LoadXFADoc(); CXFA_FFDoc* GetXFADoc() { return m_pXFADoc.get(); } - CXFA_FFDocView* GetXFADocView() { return m_pXFADocView.Get(); } + CXFA_FFDocView* GetXFADocView() const { return m_pXFADocView.Get(); } FormType GetFormType() const { return m_FormType; } bool ContainsXFAForm() const { return m_FormType == FormType::kXFAFull || |