diff options
| author | Andrew Weintraub <asweintraub@google.com> | 2018-07-17 21:42:17 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-07-17 21:42:17 +0000 |
| commit | 8e0c0dbc4876e661de6c344c759ffe22d3f13bce (patch) | |
| tree | 87f431ab072f8040868b7fd8a10f6035a8c143d1 /fpdfsdk | |
| parent | 3d7b555aa843b026c9dcb6b0f855af1d358ef2ba (diff) | |
| download | pdfium-8e0c0dbc4876e661de6c344c759ffe22d3f13bce.tar.xz | |
Add Deleter and Scoper for FPDF_PAGELINK.chromium/3495
Change-Id: Ie997bfa5437d4222a381be3fc2b4334d6c8e2d5b
Reviewed-on: https://pdfium-review.googlesource.com/38190
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fpdfsdk')
| -rw-r--r-- | fpdfsdk/fpdf_text_embeddertest.cpp | 22 |
1 files changed, 14 insertions, 8 deletions
diff --git a/fpdfsdk/fpdf_text_embeddertest.cpp b/fpdfsdk/fpdf_text_embeddertest.cpp index 112991f896..eafe1a2d11 100644 --- a/fpdfsdk/fpdf_text_embeddertest.cpp +++ b/fpdfsdk/fpdf_text_embeddertest.cpp @@ -7,6 +7,7 @@ #include <utility> #include "core/fxcrt/fx_memory.h" +#include "public/cpp/fpdf_scopers.h" #include "public/fpdf_text.h" #include "public/fpdf_transformpage.h" #include "public/fpdfview.h" @@ -321,16 +322,21 @@ TEST_F(FPDFTextEmbeddertest, WebLinks) { FPDF_TEXTPAGE textpage = FPDFText_LoadPage(page); ASSERT_TRUE(textpage); - FPDF_PAGELINK pagelink = FPDFLink_LoadWebLinks(textpage); - EXPECT_TRUE(pagelink); + { + ScopedFPDFPageLink pagelink(FPDFLink_LoadWebLinks(textpage)); + EXPECT_TRUE(pagelink); - // Page contains two HTTP-style URLs. - EXPECT_EQ(2, FPDFLink_CountWebLinks(pagelink)); + // Page contains two HTTP-style URLs. + EXPECT_EQ(2, FPDFLink_CountWebLinks(pagelink.get())); - // Only a terminating NUL required for bogus links. - EXPECT_EQ(1, FPDFLink_GetURL(pagelink, 2, nullptr, 0)); - EXPECT_EQ(1, FPDFLink_GetURL(pagelink, 1400, nullptr, 0)); - EXPECT_EQ(1, FPDFLink_GetURL(pagelink, -1, nullptr, 0)); + // Only a terminating NUL required for bogus links. + EXPECT_EQ(1, FPDFLink_GetURL(pagelink.get(), 2, nullptr, 0)); + EXPECT_EQ(1, FPDFLink_GetURL(pagelink.get(), 1400, nullptr, 0)); + EXPECT_EQ(1, FPDFLink_GetURL(pagelink.get(), -1, nullptr, 0)); + } + + FPDF_PAGELINK pagelink = FPDFLink_LoadWebLinks(textpage); + EXPECT_TRUE(pagelink); // Query the number of characters required for each link (incl NUL). EXPECT_EQ(25, FPDFLink_GetURL(pagelink, 0, nullptr, 0)); |