diff options
author | Ryan Harrison <rharrison@chromium.org> | 2018-10-05 20:43:46 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2018-10-05 20:43:46 +0000 |
commit | 06f3042167126d60184dc3c401e71924cf3b46af (patch) | |
tree | 87c5478a50178cf32a9ca761362b83db254a3ebf /fpdfsdk | |
parent | 66095ebfb9fe0b522e56753b7d1b997e65b8b219 (diff) | |
download | pdfium-06f3042167126d60184dc3c401e71924cf3b46af.tar.xz |
Remove SetSaveCalled API
This was meant to be part of a mechanism to alert users that entered
data into a PDF form was not going to actually be saved how they would
expect. The UI for this is blocked on a bug in V8, and is now being
superseded by work to correctly implement saving.
BUG=pdfium:953
Change-Id: Id9c85c109a3f6a6b4ee69d35f366006be4dc9c32
Reviewed-on: https://pdfium-review.googlesource.com/c/43552
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Diffstat (limited to 'fpdfsdk')
-rw-r--r-- | fpdfsdk/cpdfsdk_formfillenvironment.cpp | 7 | ||||
-rw-r--r-- | fpdfsdk/cpdfsdk_formfillenvironment.h | 4 | ||||
-rw-r--r-- | fpdfsdk/fpdf_formfill.cpp | 10 | ||||
-rw-r--r-- | fpdfsdk/fpdf_view_c_api_test.c | 1 |
4 files changed, 0 insertions, 22 deletions
diff --git a/fpdfsdk/cpdfsdk_formfillenvironment.cpp b/fpdfsdk/cpdfsdk_formfillenvironment.cpp index c5f9aeb133..c9bb7c94fd 100644 --- a/fpdfsdk/cpdfsdk_formfillenvironment.cpp +++ b/fpdfsdk/cpdfsdk_formfillenvironment.cpp @@ -628,13 +628,6 @@ CPDFSDK_InterForm* CPDFSDK_FormFillEnvironment::GetInterForm() { return m_pInterForm.get(); } -void CPDFSDK_FormFillEnvironment::SaveCalled() { - if (!m_pInfo || !m_SaveCalled) - return; - - m_SaveCalled(m_pInfo); -} - void CPDFSDK_FormFillEnvironment::UpdateAllViews(CPDFSDK_PageView* pSender, CPDFSDK_Annot* pAnnot) { for (const auto& it : m_PageMap) { diff --git a/fpdfsdk/cpdfsdk_formfillenvironment.h b/fpdfsdk/cpdfsdk_formfillenvironment.h index 7cdf32e15d..46986c8ae0 100644 --- a/fpdfsdk/cpdfsdk_formfillenvironment.h +++ b/fpdfsdk/cpdfsdk_formfillenvironment.h @@ -208,9 +208,6 @@ class CPDFSDK_FormFillEnvironment final CPDFSDK_ActionHandler* GetActionHandler(); // Creates if not present. CPDFSDK_InterForm* GetInterForm(); // Creates if not present. - void SetSaveCalled(FORM_SAVECALLED callback) { m_SaveCalled = callback; } - void SaveCalled(); - private: IPDF_Page* GetPage(int nIndex); @@ -226,7 +223,6 @@ class CPDFSDK_FormFillEnvironment final std::unique_ptr<CFX_SystemHandler> m_pSysHandler; bool m_bChangeMask = false; bool m_bBeingDestroyed = false; - FORM_SAVECALLED m_SaveCalled = nullptr; }; #endif // FPDFSDK_CPDFSDK_FORMFILLENVIRONMENT_H_ diff --git a/fpdfsdk/fpdf_formfill.cpp b/fpdfsdk/fpdf_formfill.cpp index 3a74bc3908..644f332db4 100644 --- a/fpdfsdk/fpdf_formfill.cpp +++ b/fpdfsdk/fpdf_formfill.cpp @@ -358,16 +358,6 @@ FPDFDOC_ExitFormFillEnvironment(FPDF_FORMHANDLE hHandle) { delete pFormFillEnv; } -FPDF_EXPORT void FPDF_CALLCONV FORM_SetSaveCallback(FPDF_FORMHANDLE hHandle, - FORM_SAVECALLED callback) { - CPDFSDK_FormFillEnvironment* pFormFillEnv = - CPDFSDKFormFillEnvironmentFromFPDFFormHandle(hHandle); - if (!pFormFillEnv) - return; - - pFormFillEnv->SetSaveCalled(callback); -} - FPDF_EXPORT FPDF_BOOL FPDF_CALLCONV FORM_OnMouseMove(FPDF_FORMHANDLE hHandle, FPDF_PAGE page, int modifier, diff --git a/fpdfsdk/fpdf_view_c_api_test.c b/fpdfsdk/fpdf_view_c_api_test.c index 2c8665156e..0fc28c31f4 100644 --- a/fpdfsdk/fpdf_view_c_api_test.c +++ b/fpdfsdk/fpdf_view_c_api_test.c @@ -249,7 +249,6 @@ int CheckPDFiumCApi() { #endif CHK(FORM_Redo); CHK(FORM_ReplaceSelection); - CHK(FORM_SetSaveCallback); CHK(FORM_Undo); CHK(FPDFDOC_ExitFormFillEnvironment); CHK(FPDFDOC_InitFormFillEnvironment); |