diff options
| author | Lei Zhang <thestig@chromium.org> | 2017-04-05 18:42:22 -0700 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-04-06 01:58:05 +0000 |
| commit | 1b22880748c3f3b3740699ae4c953a33f65ad10f (patch) | |
| tree | 57d7155639ea2f19dea22cb08ec3ce0b76bcbf9b /fxbarcode/common/reedsolomon/BC_ReedSolomon.h | |
| parent | 0b18e1599dc9d07355c4ab6a069de33a536f7ba8 (diff) | |
| download | pdfium-1b22880748c3f3b3740699ae4c953a33f65ad10f.tar.xz | |
Change some fxbarcode to use return values.
No caller cares about the exception values anyway. Remove the unused
ones. Also use more std::unique_ptr to stop potential leaks.
Change-Id: Ic5955fb0d879f55e1c6a005c0204df50246dab19
Reviewed-on: https://pdfium-review.googlesource.com/3715
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxbarcode/common/reedsolomon/BC_ReedSolomon.h')
| -rw-r--r-- | fxbarcode/common/reedsolomon/BC_ReedSolomon.h | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/fxbarcode/common/reedsolomon/BC_ReedSolomon.h b/fxbarcode/common/reedsolomon/BC_ReedSolomon.h index 42a1e002ca..68d4ee0624 100644 --- a/fxbarcode/common/reedsolomon/BC_ReedSolomon.h +++ b/fxbarcode/common/reedsolomon/BC_ReedSolomon.h @@ -7,6 +7,7 @@ #ifndef FXBARCODE_COMMON_REEDSOLOMON_BC_REEDSOLOMON_H_ #define FXBARCODE_COMMON_REEDSOLOMON_BC_REEDSOLOMON_H_ +#include <memory> #include <vector> #include "core/fxcrt/fx_basic.h" @@ -17,16 +18,16 @@ class CBC_ReedSolomonGF256Poly; class CBC_ReedSolomonEncoder { public: explicit CBC_ReedSolomonEncoder(CBC_ReedSolomonGF256* field); - virtual ~CBC_ReedSolomonEncoder(); + ~CBC_ReedSolomonEncoder(); - void Encode(std::vector<int32_t>* toEncode, size_t ecBytes, int32_t& e); - virtual void Init(); + void Init(); + bool Encode(std::vector<int32_t>* toEncode, size_t ecBytes); private: - CBC_ReedSolomonGF256Poly* BuildGenerator(size_t degree, int32_t& e); + CBC_ReedSolomonGF256Poly* BuildGenerator(size_t degree); - CBC_ReedSolomonGF256* m_field; - std::vector<CBC_ReedSolomonGF256Poly*> m_cachedGenerators; + CBC_ReedSolomonGF256* const m_field; + std::vector<std::unique_ptr<CBC_ReedSolomonGF256Poly>> m_cachedGenerators; }; #endif // FXBARCODE_COMMON_REEDSOLOMON_BC_REEDSOLOMON_H_ |